[Prerender] Cleanup prerender_util

chrome/browser/prerender/prerender_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prerender/prerender_util.h"
 
-#include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
-#include "base/metrics/sparse_histogram.h"
-#include "base/strings/string_util.h"
-#include "content/public/browser/resource_request_info.h"
-#include "content/public/common/resource_type.h"
-#include "net/http/http_response_headers.h"
-#include "net/url_request/url_request.h"
-#include "url/third_party/mozilla/url_parse.h"
-#include "url/url_canon.h"
-#include "url/url_util.h"
+#include "components/google/core/browser/google_util.h"
+#include "url/gurl.h"
 
 namespace prerender {
 
 namespace {
 
 enum PrerenderSchemeCancelReason {
   PRERENDER_SCHEME_CANCEL_REASON_EXTERNAL_PROTOCOL,
   PRERENDER_SCHEME_CANCEL_REASON_DATA,
   PRERENDER_SCHEME_CANCEL_REASON_BLOB,
   PRERENDER_SCHEME_CANCEL_REASON_FILE,
   PRERENDER_SCHEME_CANCEL_REASON_FILESYSTEM,
   PRERENDER_SCHEME_CANCEL_REASON_WEBSOCKET,
   PRERENDER_SCHEME_CANCEL_REASON_FTP,
   PRERENDER_SCHEME_CANCEL_REASON_CHROME,
   PRERENDER_SCHEME_CANCEL_REASON_CHROME_EXTENSION,
   PRERENDER_SCHEME_CANCEL_REASON_ABOUT,
   PRERENDER_SCHEME_CANCEL_REASON_UNKNOWN,
   PRERENDER_SCHEME_CANCEL_REASON_MAX,
 };
 
 void ReportPrerenderSchemeCancelReason(PrerenderSchemeCancelReason reason) {
   UMA_HISTOGRAM_ENUMERATION(
       "Prerender.SchemeCancelReason", reason,
       PRERENDER_SCHEME_CANCEL_REASON_MAX);
 }
 
 }  // namespace
 
-bool MaybeGetQueryStringBasedAliasURL(
-    const GURL& url, GURL* alias_url) {
-  DCHECK(alias_url);
-  url::Parsed parsed;
-  url::ParseStandardURL(url.spec().c_str(), url.spec().length(), &parsed);
-  url::Component query = parsed.query;
-  url::Component key, value;
-  while (url::ExtractQueryKeyValue(url.spec().c_str(), &query, &key, &value)) {
-    if (key.len != 3 || strncmp(url.spec().c_str() + key.begin, "url", key.len))
-      continue;
-    // We found a url= query string component.
-    if (value.len < 1)
-      continue;
-    url::RawCanonOutputW<1024> decoded_url;
-    url::DecodeURLEscapeSequences(url.spec().c_str() + value.begin, value.len,
-                                  &decoded_url);
-    GURL new_url(base::string16(decoded_url.data(), decoded_url.length()));
-    if (!new_url.is_empty() && new_url.is_valid()) {
-      *alias_url = new_url;
-      return true;
-    }
+bool IsGWSOriginURL(const GURL& origin_url) {

[Ilya Sherman, 2017/01/21 00:21:08]

nit: "GWS" is not a commonly understood acronym outside of Google.  Please use
something that folks are more likely to easily understand.

[droger, 2017/01/23 10:51:16]

Done.

Note: I think it was OK because "gws" is consistent with the prerender::Origin
type and UMA histograms (we have ORIGIN_GWS_PRERENDER and a "gws" family of
prerender histograms). But another name works too.

+  // ALLOW_NON_STANDARD_PORTS for integration tests with the embedded server.

[Ilya Sherman, 2017/01/21 00:21:09]

Optional: I'm not a fan of loosening production code guarantees for the sake of
testing code.  Could this be handled as an explicit dependency instead?

[droger, 2017/01/23 10:51:16]

I agree completely. This is not a new behavior introduced in this CL though, and
is non-trivial to fix.

I'm filing bug https://crbug.com/683853 for follow up.

+  if (!google_util::IsGoogleDomainUrl(origin_url,
+                                      google_util::DISALLOW_SUBDOMAIN,
+                                      google_util::ALLOW_NON_STANDARD_PORTS)) {
     return false;
   }
-  return false;
-}
 
-bool IsGoogleDomain(const GURL& url) {
-  return base::StartsWith(url.host_piece(), "www.google.",
-                          base::CompareCase::SENSITIVE);
-}
-
-bool IsGoogleSearchResultURL(const GURL& url) {
-  if (!IsGoogleDomain(url))
-    return false;
-  return (url.path_piece().empty() ||
-          base::StartsWith(url.path_piece(), "/search",
-                           base::CompareCase::SENSITIVE) ||
-          (url.path_piece() == "/") ||
-          base::StartsWith(url.path_piece(), "/webhp",
-                           base::CompareCase::SENSITIVE));
+  return (origin_url.path_piece() == "/") ||
+         google_util::IsGoogleSearchUrl(origin_url);
 }
 
 void ReportPrerenderExternalURL() {
   ReportPrerenderSchemeCancelReason(
       PRERENDER_SCHEME_CANCEL_REASON_EXTERNAL_PROTOCOL);
 }
 
 void ReportUnsupportedPrerenderScheme(const GURL& url) {
   if (url.SchemeIs("data")) {
     ReportPrerenderSchemeCancelReason(PRERENDER_SCHEME_CANCEL_REASON_DATA);
@@ skipping 14 matching lines @@
     ReportPrerenderSchemeCancelReason(
         PRERENDER_SCHEME_CANCEL_REASON_CHROME_EXTENSION);
   } else if (url.SchemeIs("about")) {
     ReportPrerenderSchemeCancelReason(PRERENDER_SCHEME_CANCEL_REASON_ABOUT);
   } else {
     ReportPrerenderSchemeCancelReason(PRERENDER_SCHEME_CANCEL_REASON_UNKNOWN);
   }
 }
 
 }  // namespace prerender