Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h

Issue 2645653003: Expose thumbnails of pages to iOS share extensions. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h
diff --git a/ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h b/ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h
index 12e9fd777bbd7235a245ac6d7fabab0b41ee81cc..93cf580775e3e7248ec7c435c4fe669ad9a1819c 100644
--- a/ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h
+++ b/ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h
@@ -8,14 +8,7 @@
#import <Foundation/Foundation.h>
#import <UIKit/UIKit.h>
-// Provides an URL and a subject to UIActivities. The subject is used by the
-// Mail UIActivities to populate the subject field.
-@interface UIActivityURLSource : NSObject<UIActivityItemSource>
-
-// Default initializer. |subject| and |url| must not be nil.
-- (instancetype)initWithURL:(NSURL*)url subject:(NSString*)subject;
-
-@end
+#import "ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator.h"
// Returns a text to the UIActivities that can take advantage of it.
@interface UIActivityTextSource : NSObject<UIActivityItemSource>
@@ -37,11 +30,16 @@
// Management App Extensions by returning a NSDictionary with the URL of the
// current page *and* also conforms to UTType public.url so it can be used
// with other Social Sharing Extensions as well. The |subject| is used by
-// Mail applications to pre-fill in the subject line.
+// Mail applications to pre-fill in the subject line. The |thumbnailGenerator|
+// is used by extensions displaying thumbnails of what is shared, for example
Olivier 2017/01/20 10:14:00 It is not really used by extension, right? It is u
jif 2017/01/24 10:29:50 Done.
+// the Chrome iOS Share Extension.
@interface UIActivityFindLoginActionSource : NSObject<UIActivityItemSource>
// Default initializer. |subject| and |url| must not be nil.
-- (instancetype)initWithURL:(NSURL*)url subject:(NSString*)subject;
+// |thumbnailGenerator| may be nil.
+- (instancetype)initWithURL:(NSURL*)url
+ subject:(NSString*)subject
+ thumbnailGenerator:(ThumbnailGenerator)thumbnailGenerator;
@end

Powered by Google App Engine
This is Rietveld 408576698