ios/chrome/browser/ui/activity_services/activity_service_controller.mm - Issue 2645653003: Expose thumbnails of pages to iOS share extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/activity_services/activity_service_controller.mm

Issue 2645653003: Expose thumbnails of pages to iOS share extensions. (Closed)

Patch Set: Addressed comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/activity_services/BUILD.gn ('k') | ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm » ('j') | ui/base/test/ios/ui_image_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/activity_services/activity_service_controller.mm

diff --git a/ios/chrome/browser/ui/activity_services/activity_service_controller.mm b/ios/chrome/browser/ui/activity_services/activity_service_controller.mm

index e5a359f87cabb2df55c43afaedec94545d386477..9211b1acda7ebb1ca3ad1a2913e189409e1870af 100644

--- a/ios/chrome/browser/ui/activity_services/activity_service_controller.mm

+++ b/ios/chrome/browser/ui/activity_services/activity_service_controller.mm

@@ -197,8 +197,10 @@

// App Extensions (e.g. 1Password) and also provide a public.url UTType

// for Share Extensions (e.g. Facebook, Twitter).

UIActivityFindLoginActionSource* loginActionProvider =

Olivier 2017/01/25 16:10:33 Still need a name change.

jif 2017/01/25 16:45:43 Added a TODO.

- [[UIActivityFindLoginActionSource alloc] initWithURL:data.nsurl

- subject:data.title];

+ [[UIActivityFindLoginActionSource alloc]

+ initWithURL:data.nsurl

+ subject:data.title

+ thumbnailGenerator:data.thumbnailGenerator];

[activityItems addObject:loginActionProvider];

UIActivityTextSource* textProvider =