Expose thumbnails of pages to iOS share extensions.

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 65 matching lines @@
 #import "ios/chrome/browser/snapshots/snapshot_overlay_provider.h"
 #import "ios/chrome/browser/storekit_launcher.h"
 #import "ios/chrome/browser/tabs/tab.h"
 #import "ios/chrome/browser/tabs/tab_dialog_delegate.h"
 #import "ios/chrome/browser/tabs/tab_headers_delegate.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/browser/tabs/tab_model_observer.h"
 #import "ios/chrome/browser/tabs/tab_snapshotting_delegate.h"
 #import "ios/chrome/browser/ui/activity_services/share_protocol.h"
 #import "ios/chrome/browser/ui/activity_services/share_to_data.h"
+#import "ios/chrome/browser/ui/activity_services/share_to_data_builder.h"
+#import "ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator.h"

[Olivier, 2017/01/20 10:14:00]

alphabetical order

[jif, 2017/01/24 10:29:50]

Done.

 #import "ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h"
 #import "ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.h"
 #import "ios/chrome/browser/ui/background_generator.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.h"
 #import "ios/chrome/browser/ui/browser_container_view.h"
 #import "ios/chrome/browser/ui/browser_view_controller_dependency_factory.h"
 #import "ios/chrome/browser/ui/chrome_web_view_factory.h"
 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
 #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
@@ skipping 492 matching lines @@
 - (void)showNoTabsUI;
 // Dismisses the No-Tabs UI with animation.
 - (void)dismissNoTabsUI;
 
 // Shows the tools menu popup.
 - (void)showToolsMenuPopup;
 // Add all delegates to the provided |tab|.
 - (void)installDelegatesForTab:(Tab*)tab;
 // Closes the current tab, with animation if applicable.
 - (void)closeCurrentTab;
-// Returns an autoreleased share to data for |tab|.
-- (ShareToData*)shareToDataForTab:(Tab*)tab;
 // Shows the menu to initiate sharing |data|.
 - (void)sharePageWithData:(ShareToData*)data;
 // Convenience method to share the current page.
 - (void)sharePage;
 // Prints the web page in the current tab.
 - (void)print;
 // Shows the Online Help Page in a tab.
 - (void)showHelpPage;
 // Show the bookmarks page.
 - (void)showAllBookmarks;
@@ skipping 3518 matching lines @@
   // Do not animate close in iPad.
   if (!IsIPadIdiom()) {
     [_contentArea addSubview:exitingPage];
     ios_internal::page_animation_util::AnimateOutWithCompletion(
         exitingPage, 0, YES, IsPortrait(), ^{
           [exitingPage removeFromSuperview];
         });
   }
 }
 
-- (ShareToData*)shareToDataForTab:(Tab*)tab {
-  // For crash documented in crbug.com/503955, tab.url which is being passed
-  // as a reference parameter caused a crash due to invalid address which
-  // which suggests that |tab| may be deallocated along the way. Check that
-  // tab is still valid by checking webState which would be deallocated if
-  // tab is being closed.
-  if (!tab.webState)
-    return nil;
-  DCHECK(tab);
-  // If the original page title exists, it is expected to match the tab title.
-  // If this ever changes, then a decision has to be made on which one should
-  // be used for sharing.
-  DCHECK(!tab.originalTitle || [tab.originalTitle isEqualToString:tab.title]);
-  BOOL isPagePrintable = [tab viewForPrinting] != nil;
-  return [[[ShareToData alloc] initWithURL:tab.url
-                                     title:tab.title
-                           isOriginalTitle:(tab.originalTitle != nil)
-                           isPagePrintable:isPagePrintable] autorelease];
-}
-
 - (void)sharePage {
-  ShareToData* data = [self shareToDataForTab:[_model currentTab]];
+  ShareToData* data =
+      activity_services::ShareToDataFromTab([_model currentTab]);
   if (data)
     [self sharePageWithData:data];
 }
 
 - (void)sharePageWithData:(ShareToData*)data {
   id<ShareProtocol> controller = [_dependencyFactory shareControllerInstance];
   if ([controller isActive])
     return;
   CGRect fromRect = [_toolbarController shareButtonAnchorRect];
   UIView* inView = [_toolbarController shareButtonView];
@@ skipping 967 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end