Expose thumbnails of pages to iOS share extensions.

ios/chrome/browser/ui/activity_services/activity_service_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/activity_services/activity_service_controller.h"
 
 #import <MobileCoreServices/MobileCoreServices.h>
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
@@ skipping 179 matching lines @@
 - (NSArray*)activityItemsForData:(ShareToData*)data {
   NSMutableArray* activityItems = [NSMutableArray array];
   // ShareToData object guarantees that there is a NSURL.
   DCHECK(data.nsurl);
 
   // In order to support find-login-action protocol, the provider object
   // UIActivityFindLoginActionSource supports both Password Management
   // App Extensions (e.g. 1Password) and also provide a public.url UTType
   // for Share Extensions (e.g. Facebook, Twitter).
   UIActivityFindLoginActionSource* loginActionProvider =
-      [[UIActivityFindLoginActionSource alloc] initWithURL:data.nsurl
-                                                   subject:data.title];
+      [[UIActivityFindLoginActionSource alloc]

[Olivier, 2017/01/20 10:14:00]

This activity is the standard one. I don't think it should be named after the
password management usage .

[pkl (ping after 24h if needed), 2017/01/20 18:30:31]

If your proposal is to rename UIActivity{FindLoginAction}Source to something
else, I'm OK with that. Do you have a name in mind?

If you are thinking of replacing this with a different type or changing the
implementation of the class UIActivityFindLoginActionSource, I'd advise you to
think further. The implementation of the method
-activityViewController:dataTypeIdentifierForActivityType: is critical for
Password Managers to function correctly.

[Olivier, 2017/01/20 19:29:25]

My suggestion was to rename the variable and/or the class and/or change the
order the actions are descibed in comment (the main usage of this action being
social media, and then password managers).

URLProvider would be more similar to textProvider and imageProvider below?

[jif, 2017/01/24 10:29:50]

I agree.
+pkl for a second opinion.

[jif, 2017/01/24 10:29:50]

Yes, I think URLProvider would be a better name. But maybe in a separate CL.

+                 initWithURL:data.nsurl
+                     subject:data.title
+          thumbnailGenerator:data.thumbnailGenerator];
   [activityItems addObject:loginActionProvider];
 
   UIActivityTextSource* textProvider =
       [[UIActivityTextSource alloc] initWithText:data.title];
   [activityItems addObject:textProvider];
 
   if (data.image) {
     UIActivityImageSource* imageProvider =
         [[UIActivityImageSource alloc] initWithImage:data.image];
     [activityItems addObject:imageProvider];
@@ skipping 82 matching lines @@
   return NO;
 }
 
 #pragma mark - For Testing
 
 - (void)setShareToDelegateForTesting:(id<ShareToDelegate>)delegate {
   shareToDelegate_ = delegate;
 }
 
 @end