Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2645633003: Fix compile errors when building with enable_vulkan=true.

Created:
3 years, 11 months ago by hyowon
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compile errors when building with enable_vulkan=true. This fixes the below compile errors. ../../gpu/vulkan/vulkan_swap_chain.h:41:5: error: use of undeclared identifier 'DCHECK_LT' DCHECK_LT(index, images_.size()); --> Added #include "base/logging.h" in vulkan_swap_chain.h. ../../content/browser/compositor/ vulkan_browser_compositor_output_surface.h:45:32: error: non-virtual member function marked 'override' hides virtual member function bool has_alpha) override; --> Added a missing parameter 'bool use_stencil'. BUG=682523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/vulkan_browser_compositor_output_surface.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/compositor/vulkan_browser_compositor_output_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/vulkan/vulkan_swap_chain.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
hyowon
Please review it. Thanks.
3 years, 11 months ago (2017-01-19 06:54:44 UTC) #3
danakj
LGTM
3 years, 11 months ago (2017-01-19 16:39:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645633003/1
3 years, 11 months ago (2017-01-19 22:29:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/345821)
3 years, 11 months ago (2017-01-19 22:47:06 UTC) #8
jbauman
lgtm
3 years, 11 months ago (2017-01-19 22:48:31 UTC) #9
hyowon
Presubmit error: Missing LGTM from an OWNER for gpu/vulkan. I've added piman and dyen. Could ...
3 years, 11 months ago (2017-01-20 01:40:21 UTC) #11
piman
On 2017/01/20 01:40:21, hyowon wrote: > Presubmit error: Missing LGTM from an OWNER for gpu/vulkan. ...
3 years, 9 months ago (2017-03-07 23:12:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645633003/1
3 years, 9 months ago (2017-03-13 21:25:44 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 22:38:22 UTC) #16
Failed to apply patch for gpu/vulkan/vulkan_swap_chain.h:
While running git apply --index -p1;
  error: patch failed: gpu/vulkan/vulkan_swap_chain.h:9
  error: gpu/vulkan/vulkan_swap_chain.h: patch does not apply

Patch:       gpu/vulkan/vulkan_swap_chain.h
Index: gpu/vulkan/vulkan_swap_chain.h
diff --git a/gpu/vulkan/vulkan_swap_chain.h b/gpu/vulkan/vulkan_swap_chain.h
index
08f39028dbcf2d4252044a6ff69d1f19d2e6d8f5..28099f89a44dc859fccabb28323ddc2deebdf88d
100644
--- a/gpu/vulkan/vulkan_swap_chain.h
+++ b/gpu/vulkan/vulkan_swap_chain.h
@@ -9,6 +9,7 @@
 #include <vector>
 #include <vulkan/vulkan.h>
 
+#include "base/logging.h"
 #include "gpu/vulkan/vulkan_export.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/swap_result.h"

Powered by Google App Engine
This is Rietveld 408576698