Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 264563008: Use SkDebugf to print when GrContext can't be created for a config. (Closed)

Created:
6 years, 7 months ago by bsalomon
Modified:
6 years, 7 months ago
Reviewers:
caryclark, benchen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Use SkDebugf to print when GrContext can't be created for a config. Also, don't label it an "Error". New output matches that of GM. BUG=skia:2494 Committed: http://code.google.com/p/skia/source/detail?r=14470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M bench/benchmain.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
6 years, 7 months ago (2014-04-30 15:13:32 UTC) #1
benchen
On 2014/04/30 15:13:32, bsalomon wrote: lgtm
6 years, 7 months ago (2014-04-30 15:26:42 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-04-30 15:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/264563008/1
6 years, 7 months ago (2014-04-30 15:46:04 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 15:54:34 UTC) #5
Message was sent while issue was closed.
Change committed as 14470

Powered by Google App Engine
This is Rietveld 408576698