Issue 264563003: Public interface of KeyedLookupCache handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264563003: Public interface of KeyedLookupCache handlified. (Closed)

Created:
6 years, 7 months ago by Igor Sheludko

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Public interface of KeyedLookupCache handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21095

Patch Set 2 : Addressing review notes #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -18 lines)			Patch
M	src/heap.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1	4 chunks	+17 lines, -12 lines	0 comments	Download
M	src/runtime.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with comment. https://codereview.chromium.org/264563003/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/264563003/diff/1/src/heap.cc#newcode6265 src/heap.cc:6265: String* internalized_string; Could we add a ...

6 years, 7 months ago (2014-04-30 14:08:25 UTC) #2

Igor Sheludko

https://codereview.chromium.org/264563003/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/264563003/diff/1/src/heap.cc#newcode6265 src/heap.cc:6265: String* internalized_string; On 2014/04/30 14:08:25, Yang wrote: > Could ...

6 years, 7 months ago (2014-04-30 14:54:37 UTC) #3

Igor Sheludko

6 years, 7 months ago (2014-04-30 15:03:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21095 (presubmit successful).

Expand Messages | Collapse Messages

Issue 264563003: Public interface of KeyedLookupCache handlified. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressing review notes #

Messages