third_party/WebKit/LayoutTests/cssom/serialize-namespaced-type-selectors.html - Issue 2645563002: Serialize type and attribute selectors as identifiers

Side by Side Diff: third_party/WebKit/LayoutTests/cssom/serialize-namespaced-type-selectors.html

Issue 2645563002: Serialize type and attribute selectors as identifiers (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/cssom/serialize-attribute-selectors.html ('k') | third_party/WebKit/Source/core/css/CSSSelector.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <style id="teststyles">	4 <style id="teststyles">

5 </style>	5 </style>

6 <script>	6 <script>

7 var ns_rule = "@namespace ns url(ns);";	7 var ns_rule = "@namespace ns url(ns);";

8 var default_ns_rules = "@namespace url(default_ns); @namespace nsdefault url (default_ns);" + ns_rule;	8 var default_ns_rules = "@namespace url(default_ns); @namespace nsdefault url (default_ns);" + ns_rule;

	9 var weird_ns_rule = "@namespace ns\\:odd url(ns);";
	rune 2017/01/18 23:29:24 Nit: I'd probably call it "escaped_ns_rule" instea Nit: I'd probably call it "escaped_ns_rule" instead. fs 2017/01/19 11:43:27 Yes, that's probably a little less colloquial =). Show quoted text On 2017/01/18 at 23:29:24, rune wrote: > Nit: I'd probably call it "escaped_ns_rule" instead. Yes, that's probably a little less colloquial =). Changed.
9	10

10 function assert_selector_serializes_to(source, expected_result) {	11 function assert_selector_serializes_to(source, expected_result) {

11 var style_element = document.getElementById("teststyles");	12 var style_element = document.getElementById("teststyles");

12 style_element.firstChild.data = source + "{ font-size: 1em; }";	13 style_element.firstChild.data = source + "{ font-size: 1em; }";

13 var sheet = style_element.sheet;	14 var sheet = style_element.sheet;

14 assert_equals(sheet.cssRules[sheet.cssRules.length - 1].selectorText, ex pected_result);	15 assert_equals(sheet.cssRules[sheet.cssRules.length - 1].selectorText, ex pected_result);

15 }	16 }

16 test(function() {	17 test(function() {

17 assert_selector_serializes_to(ns_rule + "e", "e");	18 assert_selector_serializes_to(ns_rule + "e", "e");

18 assert_selector_serializes_to(default_ns_rules + "e", "e");	19 assert_selector_serializes_to(default_ns_rules + "e", "e");

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
82 }, "Type selector with namespace equal to default namespace");	83 }, "Type selector with namespace equal to default namespace");

83 test(function() {	84 test(function() {

84 assert_selector_serializes_to(default_ns_rules + "nsdefault\|", "");	85 assert_selector_serializes_to(default_ns_rules + "nsdefault\|", "");

85 }, "Universal selector with namespace equal to default namespace");	86 }, "Universal selector with namespace equal to default namespace");

86 test(function() {	87 test(function() {

87 assert_selector_serializes_to(default_ns_rules + "nsdefault\|e.c", "e.c") ;	88 assert_selector_serializes_to(default_ns_rules + "nsdefault\|e.c", "e.c") ;

88 }, "Type selector with namespace equal to default namespace followed by clas s");	89 }, "Type selector with namespace equal to default namespace followed by clas s");

89 test(function() {	90 test(function() {

90 assert_selector_serializes_to(default_ns_rules + "nsdefault\|*.c", ".c");	91 assert_selector_serializes_to(default_ns_rules + "nsdefault\|*.c", ".c");

91 }, "Universal selector with namespace equal to default namespace followed by class");	92 }, "Universal selector with namespace equal to default namespace followed by class");

	93 test(function() {

	94 assert_selector_serializes_to(weird_ns_rule + "ns\\:odd\|e", "ns\\:odd\|e" );

	95 }, "Type selector with namespace with escaped character");

	96 test(function() {

	97 assert_selector_serializes_to(weird_ns_rule + "ns\\:odd\|odd\\:e", "ns\\: odd\|odd\\:e");

	98 }, "Type selector with escaped character and namespace with escaped characte r");

92 </script>	99 </script>

OLD	NEW