Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2645513002: Document parser event names. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
asgerf, Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -5 lines) Patch
M pkg/dart_parser/lib/src/listener.dart View 16 chunks +23 lines, -5 lines 0 comments Download
M pkg/fasta/lib/src/kernel/body_builder.dart View 86 chunks +124 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
Following up on this comment: https://codereview.chromium.org/2628043005/diff/1/pkg/fasta/lib/src/kernel/body_builder.dart#newcode306
3 years, 11 months ago (2017-01-18 11:52:22 UTC) #2
asgerf
lgtm
3 years, 11 months ago (2017-01-19 12:01:39 UTC) #3
ahe
3 years, 11 months ago (2017-01-19 12:05:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2cd77ab9c086e21355a54e8e18eabb6cbeb978cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698