Descriptionreland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's"
the original cl (hhttps://codereview.chromium.org/25667005/) was reverted because of crash in bug 304756, this cl relands it with the fixes.
this is in preparation for dynamic recent tabs model and menu:
* WrenchMenu:
- for each menu item, MenuItemView::GetCommand() used to be separate and different from MenuModel::GetCommandIdAt(model_index); they are the same now.
- different range of command id's are reserved for recent tabs and bookmarks.
- command id's of all items in the wrench menu and all its submenus can't clash, except for separator and IDC_SHOW_HISTORY, the latter of which is in both wrench menu and recent tabs submenu.
* RecentTabsSubMenuModel:
- make all command ids within range, use different ids among device name headers.
* BookmarkMenuDelegate
- makes sure only maximum number of menu items allowed is created.
- add test.
BUG=256750
TEST=wrench menu and all its submenus still work.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227675
Patch Set 1 #Patch Set 2 : fix crash w/ too many bmb items #Messages
Total messages: 5 (0 generated)
|