Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 26455004: reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's" (Closed)

Created:
7 years, 2 months ago by kuan
Modified:
7 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's" the original cl (hhttps://codereview.chromium.org/25667005/) was reverted because of crash in bug 304756, this cl relands it with the fixes. this is in preparation for dynamic recent tabs model and menu: * WrenchMenu: - for each menu item, MenuItemView::GetCommand() used to be separate and different from MenuModel::GetCommandIdAt(model_index); they are the same now. - different range of command id's are reserved for recent tabs and bookmarks. - command id's of all items in the wrench menu and all its submenus can't clash, except for separator and IDC_SHOW_HISTORY, the latter of which is in both wrench menu and recent tabs submenu. * RecentTabsSubMenuModel: - make all command ids within range, use different ids among device name headers. * BookmarkMenuDelegate - makes sure only maximum number of menu items allowed is created. - add test. BUG=256750 TEST=wrench menu and all its submenus still work. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227675

Patch Set 1 #

Patch Set 2 : fix crash w/ too many bmb items #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -153 lines) Patch
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 8 chunks +21 lines, -11 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h View 1 4 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 7 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc View 1 6 chunks +127 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.h View 6 chunks +20 lines, -35 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 20 chunks +99 lines, -87 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kuan
hi scott, i've created a new cl for easier review. 1st patch set is the ...
7 years, 2 months ago (2013-10-08 16:38:44 UTC) #1
sky
LGTM
7 years, 2 months ago (2013-10-08 20:51:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/26455004/3001
7 years, 2 months ago (2013-10-08 20:56:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/26455004/3001
7 years, 2 months ago (2013-10-09 02:29:28 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 05:01:55 UTC) #5
Message was sent while issue was closed.
Change committed as 227675

Powered by Google App Engine
This is Rietveld 408576698