Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2645493002: Increase the lifetime of Navigation Preload related objects. (Closed)
Patch Set: check fetchEvent in ServiceWorkerGlobalScopeProxy::onNavigationPreloadError Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.h
diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h
index 7bea7c7c90cd3a708fcb5bb73a764889159e551d..6d6a5d34bef88f0bbbf2d3eab18c776656c61593 100644
--- a/content/renderer/service_worker/service_worker_context_client.h
+++ b/content/renderer/service_worker/service_worker_context_client.h
@@ -271,6 +271,7 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
void OnNavigationPreloadError(
int fetch_event_id,
std::unique_ptr<blink::WebServiceWorkerError> error);
+ void OnNavigationPreloadComplete(int fetch_event_id);
falken 2017/01/18 14:24:59 Maybe it's time for a short comment for the diff b
horo 2017/01/18 16:14:57 Done.
base::WeakPtr<ServiceWorkerContextClient> GetWeakPtr();

Powered by Google App Engine
This is Rietveld 408576698