content/browser/service_worker/service_worker_fetch_dispatcher.h - Issue 2645493002: Increase the lifetime of Navigation Preload related objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.h

Issue 2645493002: Increase the lifetime of Navigation Preload related objects. (Closed)

Patch Set: check fetchEvent in ServiceWorkerGlobalScopeProxy::onNavigationPreloadError Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_fetch_dispatcher.h

diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.h b/content/browser/service_worker/service_worker_fetch_dispatcher.h

index 319f0310f5e0aeee7d25a028e960450e2cf739ce..7f745ce3ce2de7a5eb24bebd63c41ab10ecc18eb 100644

--- a/content/browser/service_worker/service_worker_fetch_dispatcher.h

+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.h

@@ -50,8 +50,8 @@ class CONTENT_EXPORT ServiceWorkerFetchDispatcher {

~ServiceWorkerFetchDispatcher();

// If appropriate, starts the navigation preload request and creates

- // |preload_handle_|.

- void MaybeStartNavigationPreload(net::URLRequest* original_request);

+ // |preload_handle_|. Returns true if it started navigation preload.

+ bool MaybeStartNavigationPreload(net::URLRequest* original_request);

// Dispatches a fetch event to the |version| given in ctor, and fires

// |fetch_callback| (also given in ctor) when finishes. It runs