third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 2645493002: Increase the lifetime of Navigation Preload related objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2645493002: Increase the lifetime of Navigation Preload related objects. (Closed)

Patch Set: fix broken-chunked-encoding-worker.js Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index bba0ca85d09187ee22f5e9030b2e5153b64a80c5..0189baf843216e5c561f40f207c0cc740a7debcc 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -212,7 +212,9 @@ void ServiceWorkerGlobalScopeProxy::onNavigationPreloadError(

int fetchEventID,

std::unique_ptr<WebServiceWorkerError> error) {

FetchEvent* fetchEvent = m_pendingPreloadFetchEvents.take(fetchEventID);

- DCHECK(fetchEvent);

+ // This method may be called after onNavigationPreloadResponse() was called.

+ if (!fetchEvent)

+ return;

fetchEvent->onNavigationPreloadError(

workerGlobalScope()->scriptController()->getScriptState(),

std::move(error));