Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.h

Issue 2645493002: Increase the lifetime of Navigation Preload related objects. (Closed)
Patch Set: fix broken-chunked-encoding-worker.js Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_dispatcher.h
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.h b/content/browser/service_worker/service_worker_fetch_dispatcher.h
index 7f745ce3ce2de7a5eb24bebd63c41ab10ecc18eb..3064d7d3393939cb2e51c1ec44e5eb608bf223ae 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.h
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.h
@@ -9,6 +9,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/optional.h"
#include "base/time/time.h"
@@ -61,6 +62,7 @@ class CONTENT_EXPORT ServiceWorkerFetchDispatcher {
private:
class ResponseCallback;
+ class URLLoaderAssets;
void DidWaitForActivation();
void StartWorker();
@@ -76,6 +78,13 @@ class CONTENT_EXPORT ServiceWorkerFetchDispatcher {
ServiceWorkerFetchEventResult fetch_result,
const ServiceWorkerResponse& response);
+ static void OnFetchEventFinished(
+ ServiceWorkerVersion* version,
+ int event_finish_id,
+ scoped_refptr<URLLoaderAssets> url_loader_assets,
+ ServiceWorkerStatusCode status,
+ base::Time dispatch_event_time);
+
ServiceWorkerMetrics::EventType GetEventType() const;
scoped_refptr<ServiceWorkerVersion> version_;
@@ -86,9 +95,9 @@ class CONTENT_EXPORT ServiceWorkerFetchDispatcher {
ResourceType resource_type_;
base::Optional<base::TimeDelta> timeout_;
bool did_complete_;
- mojom::URLLoaderFactoryPtr url_loader_factory_;
- std::unique_ptr<mojom::URLLoader> url_loader_;
- std::unique_ptr<mojom::URLLoaderClient> url_loader_client_;
+
+ scoped_refptr<URLLoaderAssets> url_loader_assets_;
+
mojom::FetchEventPreloadHandlePtr preload_handle_;
base::WeakPtrFactory<ServiceWorkerFetchDispatcher> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698