Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2645493002: Increase the lifetime of Navigation Preload related objects. (Closed)
Patch Set: incorporated falken's comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.h
diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h
index 7bea7c7c90cd3a708fcb5bb73a764889159e551d..ce822866e9859a2c9292edbd01d39dc69d1d4f2a 100644
--- a/content/renderer/service_worker/service_worker_context_client.h
+++ b/content/renderer/service_worker/service_worker_context_client.h
@@ -264,10 +264,17 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
const base::string16& message);
void OnPing();
+ // Called to resolve the FetchEvent.preloadResponse promise.
void OnNavigationPreloadResponse(
int fetch_event_id,
std::unique_ptr<blink::WebURLResponse> response,
std::unique_ptr<blink::WebDataConsumerHandle> data_consumer_handle);
+ // Called when the navigation preload request completed. Either
+ // OnNavigationPreloadComplete() or OnNavigationPreloadError() must be called
+ // to release the preload related resources.
+ void OnNavigationPreloadComplete(int fetch_event_id);
+ // Called when an error occured while recieving the response of the navigation
falken 2017/01/18 16:32:58 nit: occurred, receiving
horo 2017/01/18 16:52:06 Done.
+ // preload request.
void OnNavigationPreloadError(
int fetch_event_id,
std::unique_ptr<blink::WebServiceWorkerError> error);

Powered by Google App Engine
This is Rietveld 408576698