third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/chunked-encoding-scope.php - Issue 2645493002: Increase the lifetime of Navigation Preload related objects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/chunked-encoding-scope.php

Issue 2645493002: Increase the lifetime of Navigation Preload related objects. (Closed)

Patch Set: check fetchEvent in ServiceWorkerGlobalScopeProxy::onNavigationPreloadError Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?php

	2 function put_chunk($txt) {

	3 echo sprintf("%x\r\n", strlen($txt));

	4 echo "$txt\r\n";

	5 }

	6 header("Content-type: text/html; charset=UTF-8");

	7 header("Transfer-encoding: chunked");

	8 ob_flush();

	9 flush();

	10 usleep(10000);
	falken 2017/01/18 14:24:59 Can you comment why we need usleep and how you cho Can you comment why we need usleep and how you chose 10,000? BTW https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/test... used 1000 us. horo 2017/01/18 16:14:57 Done. But I have no specific reason to chose 10,0 Show quoted text On 2017/01/18 14:24:59, falken wrote: > Can you comment why we need usleep and how you chose 10,000? BTW > https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/test... > used 1000 us. Done. But I have no specific reason to chose 10,000.
	11 for ($i = 0; $i < 10; $i++) {

	12 put_chunk("$i");

	13 ob_flush();

	14 flush();

	15 usleep(10000);

	16 }

	17 echo "0\r\n\r\n";

	18 ?>

OLD	NEW