third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/abort-when-responded.html - Issue 2645493002: Increase the lifetime of Navigation Preload related objects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/abort-when-responded.html

Issue 2645493002: Increase the lifetime of Navigation Preload related objects. (Closed)

Patch Set: send abort error and fix flaky test and add abort-when-responded layouttest Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.cc ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/broken-chunked-encoding.html » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/abort-when-responded-worker.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>Navigation Preload request must abort when the page load finished</title>

	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <script src="../resources/test-helpers.js"></script>

	7 <script>

	8 promise_test(t => {

	9 var script = 'resources/abort-when-responded-worker.js';

	10 var scope = 'resources/abort-when-responded-scope.php';

	11 var worker;

	12 return service_worker_unregister_and_register(t, script, scope)

	13 .then(registration => {

	14 add_completion_callback(_ => registration.unregister());

	15 worker = registration.installing;

	16 return wait_for_state(t, worker, 'activated');

	17 })

	18 .then(_ => with_iframe(scope))

	19 .then(frame => {

	20 assert_equals(frame.contentDocument.body.textContent, 'OK');

	21 })

	22 .then(_ => {

	23 var saw_message = new Promise(resolve => {

	24 navigator.serviceWorker.onmessage =

	25 e => { resolve(e.data); };

	26 });

	27 worker.postMessage('');

	28 return saw_message;

	29 })

	30 .then(txt => {

	31 assert_equals(

	32 txt,

	33 'REJECTED: NetworkError: Service Worker navigation preload ' +

	34 'network error.');
	falken 2017/01/19 01:27:37 Testing the error string isn't right for an WPT te Testing the error string isn't right for an WPT test. Also the language of "abort" seems implementation-specific, it shoudl say something like "the preloadResponse promise rejects when the page load finished".
	35 });

	36 }, 'Navigation Preload request must abort when the page load finished.');

	37 </script>

OLD	NEW