third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp - Issue 2645473004: Don't clear floats when moving just some of the children in a ruby run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

Issue 2645473004: Don't clear floats when moving just some of the children in a ruby run (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp b/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

index a60916d3905cf10aa6e56503b769c464a3ad9aee..18d3e2f717d20593acc17ad81a96683db5d08c5d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

@@ -129,7 +129,7 @@ void LayoutRubyBase::moveBlockChildren(LayoutRubyBase* toBase,

if (!beforeChild)

moveAllChildrenIncludingFloatsTo(toBase, toBase->hasLayer() || hasLayer());

else

- moveChildrenTo(toBase, firstChild(), beforeChild, toBase->children());

+ moveChildrenTo(toBase, firstChild(), beforeChild);

}

ETextAlign LayoutRubyBase::textAlignmentForLine(

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-moved-crash-expected.txt ('k') | no next file » | no next file with comments »