Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 26454004: Fix alignment of <input> elements with overflow (Closed)

Created:
7 years, 2 months ago by cbiesinger
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Fix alignment of <input> elements with overflow r155341 (https://codereview.chromium.org/21414002) made us follow the CSS spec for the alignment of overflow: hidden; in combination with display: inline-block;. Unfortunately, that had the side-effect of changing the baselines for <input> elements, because we internally implement them as inline-blocks. This CL overrides the baseline computation so that they align the same way with or without overflow. (NOTE: Any websites that were broken by this can fix it by just removing overflow: hidden, because it has no effect on <input> elements) BUG=304210 R=ojan@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
A LayoutTests/fast/forms/input-baseline-overflow.html View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/input-baseline-overflow-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTextControl.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cbiesinger
7 years, 2 months ago (2013-10-08 20:57:36 UTC) #1
leviw_travelin_and_unemployed
lgtm
7 years, 2 months ago (2013-10-08 21:00:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/26454004/1
7 years, 2 months ago (2013-10-08 21:01:05 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 23:57:40 UTC) #4
Message was sent while issue was closed.
Change committed as 159173

Powered by Google App Engine
This is Rietveld 408576698