Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: tools/gn.py

Issue 2645323002: Add support for configurable -OX optimization levels for debug builds (Closed)
Patch Set: Move --debug-opt-level after --no-clang in tools/gn.py Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index df6e36ec05805bc2f14f9139445d1a3124a309ca..b30d7744a9f73e36183d3aad4608d10b7e132334 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -205,6 +205,10 @@ def to_gn_args(args, mode, arch, target_os):
gn_args['use_goma'] = False
gn_args['goma_dir'] = None
+ if args.debug_opt_level:
+ gn_args['dart_debug_optimization_level'] = args.debug_opt_level
+ gn_args['debug_optimization_level'] = args.debug_opt_level
+
return gn_args
@@ -313,6 +317,10 @@ def parse_args(args):
help='Disable Clang',
dest='clang',
action='store_false')
+ other_group.add_argument('--debug-opt-level',
+ '-d',
+ help='The optimization level to use for debug builds',
+ type=str)
other_group.add_argument('--goma',
help='Use goma',
default=True,
« no previous file with comments | « runtime/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698