Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: src/runtime/runtime-internal.cc

Issue 2645313003: [async-iteration] implement Async-from-Sync Iterator (Closed)
Patch Set: cleanmerge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-inl.h ('k') | src/v8.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/ast/prettyprinter.h" 10 #include "src/ast/prettyprinter.h"
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 RUNTIME_FUNCTION(Runtime_AllowDynamicFunction) { 504 RUNTIME_FUNCTION(Runtime_AllowDynamicFunction) {
505 HandleScope scope(isolate); 505 HandleScope scope(isolate);
506 DCHECK_EQ(1, args.length()); 506 DCHECK_EQ(1, args.length());
507 CONVERT_ARG_HANDLE_CHECKED(JSFunction, target, 0); 507 CONVERT_ARG_HANDLE_CHECKED(JSFunction, target, 0);
508 Handle<JSObject> global_proxy(target->global_proxy(), isolate); 508 Handle<JSObject> global_proxy(target->global_proxy(), isolate);
509 return *isolate->factory()->ToBoolean( 509 return *isolate->factory()->ToBoolean(
510 Builtins::AllowDynamicFunction(isolate, target, global_proxy)); 510 Builtins::AllowDynamicFunction(isolate, target, global_proxy));
511 } 511 }
512 512
513 RUNTIME_FUNCTION(Runtime_CreateAsyncFromSyncIterator) { 513 RUNTIME_FUNCTION(Runtime_CreateAsyncFromSyncIterator) {
514 // TODO(caitp): split AsyncFromSyncIterator functionality out of 514 HandleScope scope(isolate);
515 // https://codereview.chromium.org/2622833002 515 DCHECK_EQ(1, args.length());
516 UNREACHABLE(); 516
517 return isolate->heap()->undefined_value(); 517 CONVERT_ARG_HANDLE_CHECKED(Object, sync_iterator, 0);
518
519 if (!sync_iterator->IsJSReceiver()) {
520 THROW_NEW_ERROR_RETURN_FAILURE(
521 isolate, NewTypeError(MessageTemplate::kSymbolIteratorInvalid));
522 }
523
524 return *isolate->factory()->NewJSAsyncFromSyncIterator(
525 Handle<JSReceiver>::cast(sync_iterator));
518 } 526 }
519 527
520 } // namespace internal 528 } // namespace internal
521 } // namespace v8 529 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698