[async-iteration] implement Async-from-Sync Iterator

src/compiler/code-assembler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-assembler.h"
 
 #include <ostream>
 
 #include "src/code-factory.h"
 #include "src/compiler/graph.h"
@@ skipping 169 matching lines @@
 }
 
 Node* CodeAssembler::SmiConstant(int value) {
   return SmiConstant(Smi::FromInt(value));
 }
 
 Node* CodeAssembler::HeapConstant(Handle<HeapObject> object) {
   return raw_assembler()->HeapConstant(object);
 }
 
+Node* CodeAssembler::CStringConstant(const char* str) {

[jgruber, 2017/02/17 12:28:23]

Just an idea - maybe it'd make sense to add an option to create an internalized
string. That can be important e.g. if we use it for property loads.

[caitp, 2017/02/17 14:56:10]

I think most of the time in those situations we end up using string constants
from heap-symbols.h, but maybe it would be more readable to do it that way.

How would you imagine writing it? `CStringConstant("foo", true); to internalize
"foo"? Or maybe someting more like `InternalizedCStringConstant("foo");`

[jgruber, 2017/02/17 16:13:39]

Hmm, I guess both aren't really satisfying. This is probably a nonissue, I'm
fine with sticking to your current solution.

+  return HeapConstant(factory()->NewStringFromAsciiChecked(str, TENURED));
+}
+
 Node* CodeAssembler::BooleanConstant(bool value) {
   return raw_assembler()->BooleanConstant(value);
 }
 
 Node* CodeAssembler::ExternalConstant(ExternalReference address) {
   return raw_assembler()->ExternalConstant(address);
 }
 
 Node* CodeAssembler::Float64Constant(double value) {
   return raw_assembler()->Float64Constant(value);
@@ skipping 648 matching lines @@
       }
     }
   }
 
   bound_ = true;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8