Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: chrome/browser/chromeos/login/saml/saml_browsertest.cc

Issue 2645283010: Disable SAMLPolicyTest.{PRE_,}TransferCookiesUnaffiliated tests (Closed)
Patch Set: Also disable SAMLPolicyTest.TransferCookiesUnaffiliated Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <cstring> 5 #include <cstring>
6 #include <memory> 6 #include <memory>
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 1306 matching lines...) Expand 10 before | Expand all | Expand 10 after
1317 1317
1318 EnableTransferSAMLCookiesPolicy(); 1318 EnableTransferSAMLCookiesPolicy();
1319 LogInWithSAML(kFirstSAMLUserEmail, kTestAuthSIDCookie2, kTestAuthLSIDCookie2); 1319 LogInWithSAML(kFirstSAMLUserEmail, kTestAuthSIDCookie2, kTestAuthLSIDCookie2);
1320 1320
1321 GetCookies(); 1321 GetCookies();
1322 EXPECT_EQ(kTestAuthSIDCookie1, GetCookieValue(kGAIASIDCookieName)); 1322 EXPECT_EQ(kTestAuthSIDCookie1, GetCookieValue(kGAIASIDCookieName));
1323 EXPECT_EQ(kTestAuthLSIDCookie1, GetCookieValue(kGAIALSIDCookieName)); 1323 EXPECT_EQ(kTestAuthLSIDCookie1, GetCookieValue(kGAIALSIDCookieName));
1324 EXPECT_EQ(kSAMLIdPCookieValue2, GetCookieValue(kSAMLIdPCookieName)); 1324 EXPECT_EQ(kSAMLIdPCookieValue2, GetCookieValue(kSAMLIdPCookieName));
1325 } 1325 }
1326 1326
1327 IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, PRE_TransferCookiesUnaffiliated) { 1327 // Flaky on Debug, ASan and MSan bots: crbug.com/683161.
1328 IN_PROC_BROWSER_TEST_F(SAMLPolicyTest,
1329 DISABLED_PRE_TransferCookiesUnaffiliated) {
1328 fake_saml_idp()->SetCookieValue(kSAMLIdPCookieValue1); 1330 fake_saml_idp()->SetCookieValue(kSAMLIdPCookieValue1);
1329 LogInWithSAML(kDifferentDomainSAMLUserEmail, 1331 LogInWithSAML(kDifferentDomainSAMLUserEmail,
1330 kTestAuthSIDCookie1, 1332 kTestAuthSIDCookie1,
1331 kTestAuthLSIDCookie1); 1333 kTestAuthLSIDCookie1);
1332 1334
1333 GetCookies(); 1335 GetCookies();
1334 EXPECT_EQ(kTestAuthSIDCookie1, GetCookieValue(kGAIASIDCookieName)); 1336 EXPECT_EQ(kTestAuthSIDCookie1, GetCookieValue(kGAIASIDCookieName));
1335 EXPECT_EQ(kTestAuthLSIDCookie1, GetCookieValue(kGAIALSIDCookieName)); 1337 EXPECT_EQ(kTestAuthLSIDCookie1, GetCookieValue(kGAIALSIDCookieName));
1336 EXPECT_EQ(kSAMLIdPCookieValue1, GetCookieValue(kSAMLIdPCookieName)); 1338 EXPECT_EQ(kSAMLIdPCookieValue1, GetCookieValue(kSAMLIdPCookieName));
1337 } 1339 }
1338 1340
1339 // Verifies that even if the DeviceTransferSAMLCookies policy is enabled, SAML 1341 // Verifies that even if the DeviceTransferSAMLCookies policy is enabled, SAML
1340 // IdP are not transferred to a user's profile on subsequent login if the user 1342 // IdP are not transferred to a user's profile on subsequent login if the user
1341 // does not belong to the domain that the device is enrolled into. Also verifies 1343 // does not belong to the domain that the device is enrolled into. Also verifies
1342 // that GAIA cookies are not transferred. 1344 // that GAIA cookies are not transferred.
1343 IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, TransferCookiesUnaffiliated) { 1345 // Flaky on Debug, ASan and MSan bots: crbug.com/683161.
1346 IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, DISABLED_TransferCookiesUnaffiliated) {
1344 fake_saml_idp()->SetCookieValue(kSAMLIdPCookieValue2); 1347 fake_saml_idp()->SetCookieValue(kSAMLIdPCookieValue2);
1345 fake_saml_idp()->SetLoginHTMLTemplate("saml_login.html"); 1348 fake_saml_idp()->SetLoginHTMLTemplate("saml_login.html");
1346 ShowGAIALoginForm(); 1349 ShowGAIALoginForm();
1347 1350
1348 EnableTransferSAMLCookiesPolicy(); 1351 EnableTransferSAMLCookiesPolicy();
1349 LogInWithSAML(kDifferentDomainSAMLUserEmail, 1352 LogInWithSAML(kDifferentDomainSAMLUserEmail,
1350 kTestAuthSIDCookie1, 1353 kTestAuthSIDCookie1,
1351 kTestAuthLSIDCookie1); 1354 kTestAuthLSIDCookie1);
1352 1355
1353 GetCookies(); 1356 GetCookies();
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
1397 1400
1398 // Scraping one password should finish login. 1401 // Scraping one password should finish login.
1399 content::WindowedNotificationObserver session_start_waiter( 1402 content::WindowedNotificationObserver session_start_waiter(
1400 chrome::NOTIFICATION_SESSION_STARTED, 1403 chrome::NOTIFICATION_SESSION_STARTED,
1401 content::NotificationService::AllSources()); 1404 content::NotificationService::AllSources());
1402 ExecuteJsInSigninFrame("document.getElementById('Submit').click();"); 1405 ExecuteJsInSigninFrame("document.getElementById('Submit').click();");
1403 session_start_waiter.Wait(); 1406 session_start_waiter.Wait();
1404 } 1407 }
1405 1408
1406 } // namespace chromeos 1409 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698