Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2645283009: Backout part of previous commit to fix bots (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Backout part of previous commit to fix bots Committed: https://github.com/dart-lang/sdk/commit/9761ff14d4917919b040685e17e92c570b183b2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Committed patchset #1 (id:1) manually as 9761ff14d4917919b040685e17e92c570b183b2f (presubmit successful).
3 years, 11 months ago (2017-01-26 19:56:11 UTC) #2
Brian Wilkerson
I forgot to account for the fact that 'covariant' can be used as a type ...
3 years, 11 months ago (2017-01-26 19:57:05 UTC) #4
scheglov
3 years, 11 months ago (2017-01-26 20:01:05 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698