Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp

Issue 2645283008: IntersectionObserver: Always send an initial notification. (Closed)
Patch Set: Fix unit test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObserver.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp b/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp
index 825edddae8d8e7ae055f69b6c67a5fb07fc85cc5..fd14a1ea08e9ef8a55cd8d78658cad7f3102a31e 100644
--- a/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp
+++ b/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp
@@ -91,16 +91,16 @@ TEST_F(IntersectionObserverTest, ResumePostsTask) {
compositor().beginFrame();
testing::runPendingTasks();
- EXPECT_EQ(observerCallback->callCount(), 0);
+ EXPECT_EQ(observerCallback->callCount(), 1);
// When document is not suspended, beginFrame() will generate notifications
// and post a task to deliver them.
document().view()->layoutViewportScrollableArea()->setScrollOffset(
ScrollOffset(0, 300), ProgrammaticScroll);
compositor().beginFrame();
- EXPECT_EQ(observerCallback->callCount(), 0);
- testing::runPendingTasks();
EXPECT_EQ(observerCallback->callCount(), 1);
+ testing::runPendingTasks();
+ EXPECT_EQ(observerCallback->callCount(), 2);
// When a document is suspended, beginFrame() will generate a notification,
// but it will not be delivered. The notification will, however, be
@@ -109,9 +109,9 @@ TEST_F(IntersectionObserverTest, ResumePostsTask) {
document().view()->layoutViewportScrollableArea()->setScrollOffset(
ScrollOffset(0, 0), ProgrammaticScroll);
compositor().beginFrame();
- EXPECT_EQ(observerCallback->callCount(), 1);
+ EXPECT_EQ(observerCallback->callCount(), 2);
testing::runPendingTasks();
- EXPECT_EQ(observerCallback->callCount(), 1);
+ EXPECT_EQ(observerCallback->callCount(), 2);
EXPECT_FALSE(observer->takeRecords(exceptionState).isEmpty());
// Generate a notification while document is suspended; then resume document.
@@ -120,11 +120,11 @@ TEST_F(IntersectionObserverTest, ResumePostsTask) {
ScrollOffset(0, 300), ProgrammaticScroll);
compositor().beginFrame();
testing::runPendingTasks();
- EXPECT_EQ(observerCallback->callCount(), 1);
+ EXPECT_EQ(observerCallback->callCount(), 2);
document().resumeScheduledTasks();
- EXPECT_EQ(observerCallback->callCount(), 1);
- testing::runPendingTasks();
EXPECT_EQ(observerCallback->callCount(), 2);
+ testing::runPendingTasks();
+ EXPECT_EQ(observerCallback->callCount(), 3);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObserver.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698