Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html

Issue 2645283008: IntersectionObserver: Always send an initial notification. (Closed)
Patch Set: Fix unit test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html
diff --git a/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html b/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html
index 4d42e27c1f959474e7b9a0badaf4ed67da3f4d20..c4cb0e9a6773db18cccd8baae0222a6ade7a4586 100644
--- a/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html
+++ b/third_party/WebKit/LayoutTests/intersection-observer/iframe-no-root.html
@@ -41,30 +41,30 @@ iframe.onload = function() {
observer.observe(target);
entries = entries.concat(observer.takeRecords());
assert_equals(entries.length, 0, "No initial notifications.");
- runTestCycle(step0, "No notifications after first rAF.");
+ runTestCycle(step0, "First rAF.");
}, "Observer with the implicit root; target in a same-origin iframe.");
};
function step0() {
document.scrollingElement.scrollTop = 200;
runTestCycle(step1, "document.scrollingElement.scrollTop = 200");
- assert_equals(entries.length, 0, "entries.length == 0");
+ checkLastEntry(entries, 0, [8, 108, 208, 308, 0, 0, 0, 0, 0, 785, 0, 600, target]);
}
function step1() {
iframe.contentDocument.scrollingElement.scrollTop = 250;
runTestCycle(step2, "iframe.contentDocument.scrollingElement.scrollTop = 250");
- assert_equals(entries.length, 0, "entries.length == 0");
+ assert_equals(entries.length, 1, "entries.length == 1");
}
function step2() {
document.scrollingElement.scrollTop = 100;
runTestCycle(step3, "document.scrollingElement.scrollTop = 100");
- checkLastEntry(entries, 0, [8, 108, -42, 58, 8, 108, 0, 58, 0, 785, 0, 600, target]);
+ checkLastEntry(entries, 1, [8, 108, -42, 58, 8, 108, 0, 58, 0, 785, 0, 600, target]);
}
function step3() {
- checkLastEntry(entries, 1, [8, 108, -42, 58, 0, 0, 0, 0, 0, 785, 0, 600, target]);
+ checkLastEntry(entries, 2, [8, 108, -42, 58, 0, 0, 0, 0, 0, 785, 0, 600, target]);
document.scrollingElement.scrollTop = 0;
}
</script>

Powered by Google App Engine
This is Rietveld 408576698