Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

Issue 2645283008: IntersectionObserver: Always send an initial notification. (Closed)
Patch Set: Fix unit test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/ElementVisibilityObserver.h" 5 #include "core/dom/ElementVisibilityObserver.h"
6 6
7 #include "core/dom/Element.h" 7 #include "core/dom/Element.h"
8 #include "core/dom/IntersectionObserverEntry.h" 8 #include "core/dom/IntersectionObserverEntry.h"
9 #include "core/frame/LocalFrame.h" 9 #include "core/frame/LocalFrame.h"
10 #include "wtf/Functional.h" 10 #include "wtf/Functional.h"
(...skipping 13 matching lines...) Expand all
24 ExecutionContext* context = m_element->getExecutionContext(); 24 ExecutionContext* context = m_element->getExecutionContext();
25 DCHECK(context->isDocument()); 25 DCHECK(context->isDocument());
26 Document& document = toDocument(*context); 26 Document& document = toDocument(*context);
27 27
28 m_intersectionObserver = IntersectionObserver::create( 28 m_intersectionObserver = IntersectionObserver::create(
29 Vector<Length>(), Vector<float>({std::numeric_limits<float>::min()}), 29 Vector<Length>(), Vector<float>({std::numeric_limits<float>::min()}),
30 &document, WTF::bind(&ElementVisibilityObserver::onVisibilityChanged, 30 &document, WTF::bind(&ElementVisibilityObserver::onVisibilityChanged,
31 wrapWeakPersistent(this))); 31 wrapWeakPersistent(this)));
32 DCHECK(m_intersectionObserver); 32 DCHECK(m_intersectionObserver);
33 33
34 m_intersectionObserver->setInitialState(
35 IntersectionObserver::InitialState::kAuto);
36 m_intersectionObserver->observe(m_element.release()); 34 m_intersectionObserver->observe(m_element.release());
37 } 35 }
38 36
39 void ElementVisibilityObserver::stop() { 37 void ElementVisibilityObserver::stop() {
40 DCHECK(m_intersectionObserver); 38 DCHECK(m_intersectionObserver);
41 39
42 m_intersectionObserver->disconnect(); 40 m_intersectionObserver->disconnect();
43 m_intersectionObserver = nullptr; 41 m_intersectionObserver = nullptr;
44 } 42 }
45 43
46 void ElementVisibilityObserver::deliverObservationsForTesting() { 44 void ElementVisibilityObserver::deliverObservationsForTesting() {
47 m_intersectionObserver->deliver(); 45 m_intersectionObserver->deliver();
48 } 46 }
49 47
50 DEFINE_TRACE(ElementVisibilityObserver) { 48 DEFINE_TRACE(ElementVisibilityObserver) {
51 visitor->trace(m_element); 49 visitor->trace(m_element);
52 visitor->trace(m_intersectionObserver); 50 visitor->trace(m_intersectionObserver);
53 } 51 }
54 52
55 void ElementVisibilityObserver::onVisibilityChanged( 53 void ElementVisibilityObserver::onVisibilityChanged(
56 const HeapVector<Member<IntersectionObserverEntry>>& entries) { 54 const HeapVector<Member<IntersectionObserverEntry>>& entries) {
57 bool isVisible = entries.back()->intersectionRatio() > 0.f; 55 bool isVisible = entries.back()->intersectionRatio() > 0.f;
58 (*m_callback.get())(isVisible); 56 (*m_callback.get())(isVisible);
59 } 57 }
60 58
61 } // namespace blink 59 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698