components/subresource_filter/core/browser/subresource_filter_features_test_support.cc - Issue 2645283007: Add the client for accessing Subresource Filter only list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

Issue 2645283007: Add the client for accessing Subresource Filter only list. (Closed)

Patch Set: feature Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/core/browser/subresource_filter_features.cc ('k') | components/subresource_filter/core/common/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

diff --git a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

index 657e89cde0fe72b989096727ec985b111473ea30..16b8354e0e7379f7a7215f2c88c0130604324050 100644

--- a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

+++ b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

@@ -8,6 +8,7 @@

#include <memory>

#include "base/metrics/field_trial.h"

+#include "base/metrics/field_trial_params.h"

#include "components/subresource_filter/core/browser/subresource_filter_features.h"

#include "components/variations/variations_associated_data.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -41,7 +42,7 @@ ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(

ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(

base::FeatureList::OverrideState feature_state,

std::map<std::string, std::string> variation_params) {

- EXPECT_TRUE(variations::AssociateVariationParams(

+ EXPECT_TRUE(base::AssociateFieldTrialParams(

kTestFieldTrialName, kTestExperimentGroupName, variation_params));

base::FieldTrial* field_trial = base::FieldTrialList::CreateFieldTrial(