chrome/browser/subresource_filter/navigation_throttle_util.h - Issue 2645283007: Add the client for accessing Subresource Filter only list.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/subresource_filter/navigation_throttle_util.h

Issue 2645283007: Add the client for accessing Subresource Filter only list. (Closed)

Patch Set: adressed comments from jwd Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/subresource_filter/navigation_throttle_util.cc » ('j') | chrome/browser/subresource_filter/subresource_filter_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SUBRESOURCE_FILTER_NAVIGATION_THROTTLE_UTIL_H_

	6 #define CHROME_BROWSER_SUBRESOURCE_FILTER_NAVIGATION_THROTTLE_UTIL_H_

	7

	8 #include "content/public/browser/navigation_throttle.h"

	9

	10 namespace safe_browsing {

	11 class SafeBrowsingService;

	12 }
	engedy 2017/03/10 14:39:32 style nit: // namespace safe_browsing style nit: // namespace safe_browsing melandory 2017/03/15 13:41:35 I think the agreement is that when it's one line, Show quoted text On 2017/03/10 14:39:32, engedy wrote: > style nit: // namespace safe_browsing I think the agreement is that when it's one line, then // namespace safe_browsing is optional. And I on the side of the fence which proposes to omit it for 1 line forward declarations. engedy 2017/03/21 13:44:16 Acknowledged. Show quoted text On 2017/03/15 13:41:35, melandory wrote: > On 2017/03/10 14:39:32, engedy wrote: > > style nit: // namespace safe_browsing > > I think the agreement is that when it's one line, then // namespace > safe_browsing is optional. And I on the side of the fence which proposes to omit > it for 1 line forward declarations. Acknowledged.
	13

	14 content::NavigationThrottle* MaybeCreateSubresourceFilterNavigationThrottle(

	15 content::NavigationHandle* handle,
	engedy 2017/03/10 14:39:32 nit: s/handle/navigation_handle/, s/sb/safe_browsi nit: s/handle/navigation_handle/, s/sb/safe_browsing/, also in the .cc file melandory 2017/03/15 13:41:35 Done. Show quoted text On 2017/03/10 14:39:32, engedy wrote: > nit: s/handle/navigation_handle/, s/sb/safe_browsing/, also in the .cc file Done.
	16 safe_browsing::SafeBrowsingService* sb_service);

	17

	18 #endif // CHROME_BROWSER_SUBRESOURCE_FILTER_NAVIGATION_THROTTLE_UTIL_H_

OLD	NEW