tools/metrics/histograms/histograms.xml - Issue 2645283007: Add the client for accessing Subresource Filter only list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2645283007: Add the client for accessing Subresource Filter only list. (Closed)

Patch Set: adressed comments from jwd Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 9658b2ee6db123ea65e1381698a0a5463d82d1bc..5e21f3b163c330953b534945bc31f28edb16a1e8 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -67709,7 +67709,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>melandory@chromium.org</owner>

- <summary>Total length of the server redirects during the navigation.</summary>

+ <summary>

+ Total number of server redirects during the navigation. This histogram

jwd 2017/03/08 22:59:26 Nit: whitespace. Was it added by our pretty print

melandory 2017/03/09 15:48:45 Yep. It was new line before.

+ is recorded in several flavours: with prefix SubresourceFilterOnly in

+ case the redirect chain contains url from the Safe Browsing

+ SubresourceFilter list and without the prefix for all other redirect

+ chains.

+ </summary>

</histogram>

<histogram name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"

@@ -67721,7 +67727,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

For example, for the redirect chain A-B-C-D metric tracks: 1. If initial URL

(A) was on a Safe Browsing blacklist. 2. If any if middle urls (B, C) were

on a Safe Browsing blacklist. 3. If committed URL (B) was on a Safe Browsing

- blacklist.

+ blacklist. This histogram is recorded in several flavours: with prefix

+ SubresourceFilterOnly in case the redirect chain contains url from the Safe

+ Browsing SubresourceFilter list and without the prefix for all other

+ redirect chains.

</summary>

</histogram>

@@ -120582,6 +120591,13 @@ value.

<affected-histogram name="WebRTC.Stun.SuccessPercent.UnknownNAT"/>

</histogram_suffixes>

+<histogram_suffixes name="SubresourceFilterOnlyExperiment" separator=".">

+ <suffix name="SubresourceFilterOnly"/>

+ <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/>

+ <affected-histogram

+ name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"/>

+</histogram_suffixes>

<histogram_suffixes name="SyncModelType" separator=".">

« no previous file with comments | « components/subresource_filter/core/common/activation_list.cc ('k') | no next file » | no next file with comments »