chrome/browser/subresource_filter/subresource_filter_navigation_trottle_util.cc - Issue 2645283007: Add the client for accessing Subresource Filter only list.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/subresource_filter/subresource_filter_navigation_trottle_util.cc

Issue 2645283007: Add the client for accessing Subresource Filter only list. (Closed)

Patch Set: fix unittest Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/subresource_filter/subresource_filter_navigation_trottle_util.h ('K') | « chrome/browser/subresource_filter/subresource_filter_navigation_trottle_util.h ('k') | components/subresource_filter/content/browser/BUILD.gn » ('j') | components/subresource_filter/content/browser/subresource_filter_activation_navigation_throttle.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/subresource_filter/subresource_filter_navigation_trottl e_util.h"

	6

	7 #include "base/memory/ptr_util.h"

	8 #include "chrome/browser/safe_browsing/safe_browsing_service.h"

	9 #include "components/safe_browsing_db/v4_feature_list.h"

	10 #include "components/subresource_filter/content/browser/subresource_filter_activ ation_navigation_throttle.h"

	11 #include "content/public/browser/navigation_handle.h"

	12

	13 std::unique_ptr<content::NavigationThrottle>

	14 MaybeCreateSubresourceFilterNavigationThrottle(

	15 content::NavigationHandle* handle,

	16 safe_browsing::SafeBrowsingService* sb_service) {

	17 if (handle->IsInMainFrame() &&

	18 sb_service->database_manager()->IsSupported() &&

	19 (safe_browsing::V4FeatureList::IsV4HybridEnabled() \|\|
	vakh (use Gerrit instead) 2017/02/10 03:00:12 these methods are going away soon so don't be surp these methods are going away soon so don't be surprised if your build breaks after a rebase. See: https://codereview.chromium.org/2675063002/#ps160001 melandory 2017/02/14 17:40:34 Rebased on top of it. Show quoted text On 2017/02/10 03:00:12, vakh (Varun Khaneja) wrote: > these methods are going away soon so don't be surprised if your build breaks > after a rebase. > See: https://codereview.chromium.org/2675063002/#ps160001 Rebased on top of it.
	20 safe_browsing::V4FeatureList::IsV4OnlyEnabled())) {

	21 return base::WrapUnique(

	22 new subresource_filter::SubresourceFilterActivationNavigationThrottle(

	23 handle, sb_service->v4_local_database_manager()));

	24 }

	25 return nullptr;

	26 }

OLD	NEW