Convert make_qualified_names and make_element_factory to use JSON5.

third_party/WebKit/Source/build/scripts/json5_generator.py

Index: third_party/WebKit/Source/build/scripts/json5_generator.py
diff --git a/third_party/WebKit/Source/build/scripts/json5_generator.py b/third_party/WebKit/Source/build/scripts/json5_generator.py
index 00f4e9ad937ce91117d6005bf843b78ce5a2a332..e7a21b23763d64e2649427fdeb42be9726dbf882 100644
--- a/third_party/WebKit/Source/build/scripts/json5_generator.py
+++ b/third_party/WebKit/Source/build/scripts/json5_generator.py
@@ -153,14 +153,17 @@ class Json5File(object):
         if "name" not in item:
             raise Exception("Missing name in item: %s" % item)
         entry["name"] = item.pop("name")
+        # Valid parameters if it's specified.
         for key, value in item.items():
+            entry[key] = value

[sashab, 2017/01/31 23:09:19]

Why did you move this up here?

[ktyliu, 2017/01/31 23:42:06]

I am doing a "continue" below (for the case where parameters isn't specified),
so I had to copy over the items over before skipping

I've now changed it to the alternative of doing dict update instead,
hope you like this version better or otherwise I can revert back

+            if not self.parameters:
+                continue
             if key not in self.parameters:
                 raise Exception(
                     "Unknown parameter: '%s'\nKnown params: %s" %
                     (key, self.parameters.keys()))
             if self.parameters[key]:
                 self._validate_parameter(self.parameters[key], value)
-            entry[key] = value
         return entry
 
     def _validate_parameter(self, parameter, value):