Convert make_qualified_names and make_element_factory to use JSON5.

third_party/WebKit/Source/build/scripts/json5_generator.py

 # Copyright (c) 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic generator for configuration files in JSON5 format.
 
 The configuration file is expected to contain either a data array or a data map,
 an optional parameters validation map, and an optional metdata map. Examples:
 {
   data: [
@@ skipping 135 matching lines @@
                 self._defaults[key] = None
 
     def _get_entry(self, item):
         entry = copy.deepcopy(self._defaults)
         if type(item) is not dict:
             entry["name"] = item
             return entry
         if "name" not in item:
             raise Exception("Missing name in item: %s" % item)
         entry["name"] = item.pop("name")
+        # Valid parameters if it's specified.
         for key, value in item.items():
+            entry[key] = value

[sashab, 2017/01/31 23:09:19]

Why did you move this up here?

[ktyliu, 2017/01/31 23:42:06]

I am doing a "continue" below (for the case where parameters isn't specified),
so I had to copy over the items over before skipping

I've now changed it to the alternative of doing dict update instead,
hope you like this version better or otherwise I can revert back

+            if not self.parameters:
+                continue
             if key not in self.parameters:
                 raise Exception(
                     "Unknown parameter: '%s'\nKnown params: %s" %
                     (key, self.parameters.keys()))
             if self.parameters[key]:
                 self._validate_parameter(self.parameters[key], value)
-            entry[key] = value
         return entry
 
     def _validate_parameter(self, parameter, value):
         valid_values = parameter.get("valid_values")
         if valid_values and value not in valid_values:
             raise Exception("Unknown value: '%s'\nKnown values: %s" %
                             (value, valid_values))
         valid_type = parameter.get("valid_type")
         if valid_type and type(value).__name__ != valid_type:
             raise Exception("Incorrect type: '%s'\nExpected type: %s" %
@@ skipping 54 matching lines @@
         parser.add_argument("--developer_dir", help="Path to Xcode.")
         parser.add_argument("--output_dir", default=os.getcwd())
         args = parser.parse_args()
 
         if args.developer_dir:
             os.environ["DEVELOPER_DIR"] = args.developer_dir
 
         writer = self._writer_class(args.files)
         writer.set_gperf_path(args.gperf)
         writer.write_files(args.output_dir)