Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2645283005: Fix crash when using type parameters on custom elements (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix crash when using type parameters on custom elements The fix ensures that the custom element '.created' constructor has 'receiver' as the first argument. This prevents the crash reported in https://github.com/dart-lang/sdk/issues/28457 The type arguments will be seen as 'dynamic' because there is no way to specify them from document.createElement or HTML. TBR=sigmund@google.com BUG= https://github.com/dart-lang/sdk/issues/28457 Committed: https://github.com/dart-lang/sdk/commit/12300fa688c3762f8d040582a4ab5e050500c054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
sra1
Committed patchset #1 (id:1) manually as 12300fa688c3762f8d040582a4ab5e050500c054 (presubmit successful).
3 years, 11 months ago (2017-01-25 02:25:18 UTC) #3
Siggi Cherem (dart-lang)
3 years, 11 months ago (2017-01-25 15:57:55 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698