DesktopAura: Track windows "owned" via the DesktopWindowTreeHost

ui/views/accessibility/native_view_accessibility.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/events/event_utils.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/controls/native/native_view_host.h"
@@ skipping 237 matching lines @@
 }
 
 void NativeViewAccessibility::PopulateChildWidgetVector(
     std::vector<Widget*>* result_child_widgets) {
   // Only attach child widgets to the root view.
   Widget* widget = view_->GetWidget();
   if (!widget || widget->GetRootView() != view_)
     return;
 
   std::set<Widget*> child_widgets;
-  Widget::GetAllOwnedWidgets(widget->GetNativeView(), &child_widgets);
+  Widget::GetAllOwnedWidgets(widget->GetNativeView(), &child_widgets, false);

[tapted, 2017/01/25 11:23:03]

I don't think the concept of "ownership" here extends to top-level Widgets. That
is, I think a11y clients would get confused if we started populating a11y info
from another toplevel window in the OS. So, I added the extra argument.

[sky, 2017/01/25 16:41:24]

It's my understanding GetAllOwnedWidget is only called by accessibility. Did you
need to start using it outside of that?

[tapted, 2017/01/27 05:34:55]

Yes - it forms part of http://crbug.com/654151 (added that to BUG=). In the
latest patchset, I've included the change to test_browser_dialog.cc that would
use GetAllOwnedWidget() to give specific context.


There's a bit more in that first BUG= too, i.e. http://crbug.com/683808#c3 says,

"""Note this became an problem for http://crbug.com/681049 because the
dialog-testing harness (TestBrowserDialog) wants to use
Widget::GetAllOwnedWidgets() to detect when a dialog is added to the Chrome
Browser window."""

That is, currently TestBrowserDialog needs a way to (1.) verify that a test case
added a dialog to Chrome, and (2.) close that dialog. GetAllOwnedWidgets() comes
really close to solving this, but didn't work on Windows 10 where
chrome_views_delegate.cc detects Aero and makes a top-level window.


Of course, that's still testing code :/. I didn't realise how much thread I'd be
pulling on when I started down this path.

It does seem that `GetAllOwnedWidgets()` isn't fulfilling its contract right
now, so maybe this is the right approach.

An alternative may be to add some Win- and X11- specific code to
test_browser_dialog.cc that scans through OS window handles and checks for new
Widgets that appear there. 

E.g. 
for (XID xid : DWTHX11PrivateApi::open_windows()) {
 
Widget::GetWidgetForNativeWindow(DestkopWindowTreeHostX11::GetContentWindowForXID(xid));
}

and... something more verbose for Windows.

Not sure how to do this on mus -- probably something involving
views::MusClient::Get()->window_tree_client()->GetRoots() -- which is something
I stole from GetLocalProcessWindowAtPointMus(). I note that appears to be
relying on the duplicate `RegisterNativeWidgetForWindow` entry, I think it could
instead use Widgets::GetAllOwnedWidgets() (I don't think it would need the
changes in this CL, however).

[tapted, 2017/01/30 10:33:04]

/* snip */

In case this pops in your queue first, I've explored this alternative at
https://codereview.chromium.org/2660813002/

   for (auto iter = child_widgets.begin(); iter != child_widgets.end(); ++iter) {
     Widget* child_widget = *iter;
     DCHECK_NE(widget, child_widget);
 
     if (!child_widget->IsVisible())
       continue;
 
     if (widget->GetNativeWindowProperty(kWidgetNativeViewHostKey))
       continue;
 
     gfx::NativeViewAccessible child_widget_accessible =
         child_widget->GetRootView()->GetNativeViewAccessible();
     ui::AXPlatformNode* child_widget_platform_node =
         ui::AXPlatformNode::FromNativeViewAccessible(child_widget_accessible);
     if (child_widget_platform_node) {
       NativeViewAccessibility* child_widget_view_accessibility =
           static_cast<NativeViewAccessibility*>(
               child_widget_platform_node->GetDelegate());
       if (child_widget_view_accessibility->parent_widget() != widget)
         child_widget_view_accessibility->SetParentWidget(widget);
     }
 
     result_child_widgets->push_back(child_widget);
   }
 }
 
 }  // namespace views