Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3959)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java

Issue 2645243002: (Android) Removing deprecated methods in chrome_junit_tests (Closed)
Patch Set: Patch version after last code changes from other members Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
index 6ab4d4ac0dc2e091db7f3139b3b7c0bd430bbf43..a4cfab3d6914837383b461b0220c7ca155d0ad25 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
@@ -7,7 +7,6 @@ package org.chromium.chrome.browser.offlinepages;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyListOf;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.spy;
@@ -126,9 +125,10 @@ public class OfflinePageBridgeUnitTest {
answerNativeGetAllPages(itemCount);
Callback<List<OfflinePageItem>> callback = createMultipleItemCallback(itemCount);
-
mBridge.getAllPages(callback);
- verify(callback, times(1)).onResult(anyListOf(OfflinePageItem.class));
+
+ List<OfflinePageItem> itemList = new ArrayList<OfflinePageItem>();
+ verify(callback, times(1)).onResult(itemList);
}
/**
@@ -141,9 +141,12 @@ public class OfflinePageBridgeUnitTest {
answerNativeGetAllPages(itemCount);
Callback<List<OfflinePageItem>> callback = createMultipleItemCallback(itemCount);
-
mBridge.getAllPages(callback);
- verify(callback, times(1)).onResult(anyListOf(OfflinePageItem.class));
+
+ List<OfflinePageItem> itemList = new ArrayList<OfflinePageItem>();
+ itemList.add(TEST_OFFLINE_PAGE_ITEM);
+ itemList.add(TEST_OFFLINE_PAGE_ITEM);
+ verify(callback, times(1)).onResult(itemList);
}
/**
@@ -153,14 +156,15 @@ public class OfflinePageBridgeUnitTest {
@Feature({"OfflinePages"})
public void testGetPagesByClientIds_listOfClientIdsEmpty() {
final int itemCount = 0;
- answerGetPagesByClientIds(itemCount);
+ answerGetPagesByClientIds(itemCount);
Callback<List<OfflinePageItem>> callback = createMultipleItemCallback(itemCount);
ClientId secondClientId = new ClientId(TEST_NAMESPACE, "id number two");
List<ClientId> list = new ArrayList<>();
mBridge.getPagesByClientIds(list, callback);
- verify(callback, times(1)).onResult(anyListOf(OfflinePageItem.class));
+ List<OfflinePageItem> itemList = new ArrayList<OfflinePageItem>();
+ verify(callback, times(1)).onResult(itemList);
}
/**
@@ -170,8 +174,8 @@ public class OfflinePageBridgeUnitTest {
@Feature({"OfflinePages"})
public void testGetPagesByClientIds() {
final int itemCount = 2;
- answerGetPagesByClientIds(itemCount);
+ answerGetPagesByClientIds(itemCount);
Callback<List<OfflinePageItem>> callback = createMultipleItemCallback(itemCount);
ClientId secondClientId = new ClientId(TEST_NAMESPACE, "id number two");
List<ClientId> list = new ArrayList<>();
@@ -179,7 +183,10 @@ public class OfflinePageBridgeUnitTest {
list.add(secondClientId);
mBridge.getPagesByClientIds(list, callback);
- verify(callback, times(1)).onResult(anyListOf(OfflinePageItem.class));
+ List<OfflinePageItem> itemList = new ArrayList<OfflinePageItem>();
+ itemList.add(TEST_OFFLINE_PAGE_ITEM);
+ itemList.add(TEST_OFFLINE_PAGE_ITEM);
+ verify(callback, times(1)).onResult(itemList);
}
/**
@@ -189,8 +196,8 @@ public class OfflinePageBridgeUnitTest {
@Feature({"OfflinePages"})
public void testDeletePagesByClientIds_listOfClientIdsEmpty() {
final int itemCount = 0;
- answerDeletePagesByClientIds(itemCount);
+ answerDeletePagesByClientIds(itemCount);
Callback<Integer> callback = createDeletePageCallback();
ClientId secondClientId = new ClientId(TEST_NAMESPACE, "id number two");
List<ClientId> list = new ArrayList<>();
@@ -206,8 +213,8 @@ public class OfflinePageBridgeUnitTest {
@Feature({"OfflinePages"})
public void testDeletePagesByClientIds() {
final int itemCount = 2;
- answerDeletePagesByClientIds(itemCount);
+ answerDeletePagesByClientIds(itemCount);
Callback<Integer> callback = createDeletePageCallback();
ClientId secondClientId = new ClientId(TEST_NAMESPACE, "id number two");
List<ClientId> list = new ArrayList<>();

Powered by Google App Engine
This is Rietveld 408576698