Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: scripts/slave/recipes/cronet.py

Issue 264523003: Upload_build prior to running tests and add common tests steps to cronet recipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'chromium', 6 'chromium',
7 'chromium_android', 7 'chromium_android',
8 'properties', 8 'properties',
9 'json', 9 'json',
10 'path', 10 'path',
(...skipping 20 matching lines...) Expand all
31 REPO_NAME='src', 31 REPO_NAME='src',
32 REPO_URL='svn://svn-mirror.golo.chromium.org/chrome/trunk/src', 32 REPO_URL='svn://svn-mirror.golo.chromium.org/chrome/trunk/src',
33 INTERNAL=False) 33 INTERNAL=False)
34 droid.c.deps_file = 'DEPS' 34 droid.c.deps_file = 'DEPS'
35 35
36 yield droid.init_and_sync() 36 yield droid.init_and_sync()
37 yield droid.envsetup() 37 yield droid.envsetup()
38 yield droid.clean_local_files() 38 yield droid.clean_local_files()
39 yield droid.runhooks() 39 yield droid.runhooks()
40 yield droid.compile() 40 yield droid.compile()
41 yield droid.upload_build()
41 42
42 if builder_config['run_tests']: 43 if builder_config['run_tests']:
43 yield droid.device_status_check() 44 yield droid.common_tests_setup_steps()
44 install_cmd = api.path['checkout'].join('build', 45 install_cmd = api.path['checkout'].join('build',
45 'android', 46 'android',
46 'adb_install_apk.py') 47 'adb_install_apk.py')
47 yield api.python('install CronetSample', install_cmd, 48 yield api.python('install CronetSample', install_cmd,
48 args = ['--apk', 'CronetSample.apk']) 49 args = ['--apk', 'CronetSample.apk'])
49 test_cmd = api.path['checkout'].join('build', 50 test_cmd = api.path['checkout'].join('build',
50 'android', 51 'android',
51 'test_runner.py') 52 'test_runner.py')
52 yield api.python('test CronetSample', test_cmd, 53 yield api.python('test CronetSample', test_cmd,
53 args = ['instrumentation', '--test-apk', 'CronetSampleTest']) 54 args = ['instrumentation', '--test-apk', 'CronetSampleTest'])
54 yield droid.upload_build() 55 yield droid.common_tests_final_steps()
55 yield droid.cleanup_build() 56 else:
57 yield droid.cleanup_build()
56 58
57 def _sanitize_nonalpha(text): 59 def _sanitize_nonalpha(text):
58 return ''.join(c if c.isalnum() else '_' for c in text.lower()) 60 return ''.join(c if c.isalnum() else '_' for c in text.lower())
59 61
60 def GenTests(api): 62 def GenTests(api):
61 bot_ids = ['Android Cronet Builder (dbg)', 'Android Cronet Builder'] 63 bot_ids = ['Android Cronet Builder (dbg)', 'Android Cronet Builder']
62 64
63 for bot_id in bot_ids: 65 for bot_id in bot_ids:
64 props = api.properties( 66 props = api.properties(
65 buildername=bot_id, 67 buildername=bot_id,
66 revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00', 68 revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00',
67 ) 69 )
68 yield api.test(_sanitize_nonalpha(bot_id)) + props 70 yield api.test(_sanitize_nonalpha(bot_id)) + props
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698