Use centered app list position whenever virtual keyboard is allowed.

Use centered app list position whenever virtual keyboard is allowed.

Previously, the app list would be centered only when the virtual
keyboard is enabled. Now it is centered whenever the virtual keyboard
might be enabled, with the following new cases:
- If --ash-enable-touch-view-testing is on.
- If any accelerometer data is detected (as this can trigger virtual
keyboard).

BUG=369382
TEST=Run ChromeOS with --ash-enable-touch-view-testing. App launcher
should be centered and landscape.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269556

[Matt Giuca, 2014-05-06 06:11:25]

This is a follow-up to SVN 268443 (https://codereview.chromium.org/253983002/).
That CL made the app list come up centered whenever the virtual keyboard is
enabled. This one makes it come up centered all the time on devices that can
switch into virtual keyboard mode (i.e., the accelerometer is giving us data, or
the --ash-enable-touch-view-testing flag is on).

flackr: ash/wm/maximize_mode/maximize_mode_controller.*
benwells: chrome/browser/ui/app_list/app_list_view_delegate.cc
varkha: For your interest (since you reviewed the previous CL).

[flackr, 2014-05-06 15:55:03]

Code lgtm, though I'm a little hesitant about centering the app list all the
time on these devices.

[benwells, 2014-05-07 00:27:50]

lgtm

[Matt Giuca, 2014-05-07 00:36:46]

On 2014/05/06 15:55:03, flackr wrote:
> Code lgtm, though I'm a little hesitant about centering the app list all the
> time on these devices.

There was an extensive offline debate about this (you're CCd on it). It was a
product decision which we can revisit at a later time, but for now, we need this
in M36.

[Matt Giuca, 2014-05-07 00:36:58]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-07 00:38:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/264523002/40001

[commit-bot: I haz the power, 2014-05-07 12:45:57]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium

[Matt Giuca, 2014-05-07 14:17:13]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2014-05-07 22:27:13]

The failures looked like I caused them (since they're App List tests) but I
don't know, they look kind of unrelated and flaky. Trying again...

[Matt Giuca, 2014-05-07 22:27:19]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-07 22:30:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/264523002/40001

[commit-bot: I haz the power, 2014-05-08 18:17:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-08 23:41:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 23:41:11]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Matt Giuca, 2014-05-09 00:49:40]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-09 00:57:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/264523002/40001

[Matt Giuca, 2014-05-09 07:37:10]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-09 07:43:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/264523002/120001

[Matt Giuca, 2014-05-09 07:44:20]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2014-05-09 08:19:29]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-09 08:21:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/264523002/120001

[commit-bot: I haz the power, 2014-05-10 07:51:30]

Change committed as 269556