Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: components/spellcheck/renderer/spellcheck_unittest.cc

Issue 2645123002: [spellcheck] Re-enable Windows tests (Closed)
Patch Set: Forgot comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/spellcheck/renderer/spellcheck_unittest.cc
diff --git a/components/spellcheck/renderer/spellcheck_unittest.cc b/components/spellcheck/renderer/spellcheck_unittest.cc
index 3c09b7b7035d3f07fd77502d087efbc6ff172530..4077b8eb4d3a190ce5ef627483a1e4371bfe48cc 100644
--- a/components/spellcheck/renderer/spellcheck_unittest.cc
+++ b/components/spellcheck/renderer/spellcheck_unittest.cc
@@ -178,13 +178,7 @@ class MockTextCheckingCompletion : public blink::WebTextCheckingCompletion {
// A test with a "[ROBUSTNESS]" mark shows it is a robustness test and it uses
// grammatically incorrect string.
// TODO(groby): Please feel free to add more tests.
-#if defined(OS_WIN) && !defined(NDEBUG)
-// Test times out on win dbg. crbug.com/678753.
-#define MAYBE_SpellCheckStrings_EN_US DISABLED_SpellCheckStrings_EN_US
-#else
-#define MAYBE_SpellCheckStrings_EN_US SpellCheckStrings_EN_US
-#endif
-TEST_F(SpellCheckTest, MAYBE_SpellCheckStrings_EN_US) {
+TEST_F(SpellCheckTest, SpellCheckStrings_EN_US) {
static const struct {
// A string to be tested.
const wchar_t* input;
@@ -495,10 +489,9 @@ TEST_F(SpellCheckTest, SpellCheckSuggestions_EN_US) {
// This test verifies our spellchecker can split a text into words and check
// the spelling of each word in the text.
-#if defined(THREAD_SANITIZER) || defined(OS_WIN)
+#if defined(THREAD_SANITIZER)
groby-ooo-7-16 2017/01/23 21:08:11 Once this has landed, could you give this another
// SpellCheckTest.SpellCheckText fails under ThreadSanitizer v2.
// See http://crbug.com/217909.
-// Also fails on windows: crbug.com/678300.
#define MAYBE_SpellCheckText DISABLED_SpellCheckText
#else
#define MAYBE_SpellCheckText SpellCheckText
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698