Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: credentials.h

Issue 2645008: Update on feedback, update dbus API, add unit tests. TEST=manual,unit,BVT BUG=3628 323 (Closed) Base URL: ssh://git@chromiumos-git/cryptohome.git
Patch Set: Address second round of feedback. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « SConstruct ('k') | crypto.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: credentials.h
diff --git a/credentials.h b/credentials.h
index 9f4951e2257d4624206a29004cf3be867063fc98..d6347554a788314e2b2964c43ed7607ea8a9b99d 100644
--- a/credentials.h
+++ b/credentials.h
@@ -8,7 +8,7 @@
#ifndef CRYPTOHOME_CREDENTIALS_H_
#define CRYPTOHOME_CREDENTIALS_H_
-#include "cryptohome/secure_blob.h"
+#include "secure_blob.h"
namespace cryptohome {
@@ -26,7 +26,10 @@ class Credentials {
virtual void GetFullUsername(char *name_buffer, int length) const = 0;
// Returns the full user name as a std::string
- virtual std::string GetFullUsername() const = 0;
+ //
+ // Parameters
+ //
+ virtual std::string GetFullUsernameString() const = 0;
// Returns the part of the username before the '@'
//
@@ -44,10 +47,10 @@ class Credentials {
// Returns a the user's passkey
//
- // Returns
- // A SecureBlob containing the passkey
+ // Parameters
+ // passkey - A SecureBlob containing the passkey
//
- virtual SecureBlob GetPasskey() const = 0;
+ virtual void GetPasskey(SecureBlob* passkey) const = 0;
};
} // namespace cryptohome
« no previous file with comments | « SConstruct ('k') | crypto.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698