Cleanup: Adding more conversion helper interfaces.

Source/web/ChromeClientImpl.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 170 matching lines @@
     virtual bool shouldRubberBandInDirection(WebCore::ScrollDirection) const;
     virtual void numWheelEventHandlersChanged(unsigned);
 
     virtual bool requestPointerLock();
     virtual void requestPointerUnlock();
     virtual bool isPointerLocked();
 
     virtual void didAssociateFormControls(const Vector<RefPtr<WebCore::Element> >&) OVERRIDE;
 
 private:
+    virtual bool isChromeClient() const OVERRIDE { return true; }
+
     WebNavigationPolicy getNavigationPolicy();
     void getPopupMenuInfo(WebCore::PopupContainer*, WebPopupMenuInfo*);
     void setCursor(const WebCursorInfo&);
 
     WebViewImpl* m_webView;  // weak pointer
     bool m_toolbarsVisible;
     bool m_statusbarVisible;
     bool m_scrollbarsVisible;
     bool m_menubarVisible;
     bool m_resizable;
 
     WebCore::PagePopupDriver* m_pagePopupDriver;
 };
 
 #if ENABLE(NAVIGATOR_CONTENT_UTILS)
 class NavigatorContentUtilsClientImpl : public WebCore::NavigatorContentUtilsClient {
 public:
     static PassOwnPtr<NavigatorContentUtilsClientImpl> create(WebViewImpl*);
     ~NavigatorContentUtilsClientImpl() { }
 
     virtual void registerProtocolHandler(const String& scheme, const String& baseURL, const String& url, const String& title) OVERRIDE;
 
 private:
     explicit NavigatorContentUtilsClientImpl(WebViewImpl*);
 
     WebViewImpl* m_webView;
 };
 #endif
 
+inline ChromeClientImpl* toChromeClientImpl(WebCore::ChromeClient* client)
+{
+    // No need for null check, as the client returned by Page::client() is actually a reference.

[tkent, 2013/10/08 22:22:39]

So, we should have
  inline ChromeClientImpl* toChromeClientImpl(ChromeClient& client) or
  inline ChromeClientImpl& toChromeClientImpl(ChromeClient& client)

+    ASSERT_WITH_SECURITY_IMPLICATION(client->isChromeClient());
+    return static_cast<ChromeClientImpl*>(client);
+}
+
 } // namespace WebKit
 
 #endif