Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: components/omnibox/browser/autocomplete_match.cc

Issue 2644903004: Move around more vector icons. (Closed)
Patch Set: fix comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/autocomplete_match.h ('k') | components/omnibox/browser/omnibox_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/autocomplete_match.cc
diff --git a/components/omnibox/browser/autocomplete_match.cc b/components/omnibox/browser/autocomplete_match.cc
index c8b890d060aa8286c1cff9e6b9c3e75d5f5f7f52..bb65962d25471a7ebdf33546750e80e9acd395ac 100644
--- a/components/omnibox/browser/autocomplete_match.cc
+++ b/components/omnibox/browser/autocomplete_match.cc
@@ -20,7 +20,11 @@
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_service.h"
#include "components/url_formatter/url_formatter.h"
-#include "ui/gfx/vector_icons_public.h"
+#include "ui/gfx/vector_icon_types.h"
+
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#include "components/omnibox/browser/vector_icons.h" // nogncheck
+#endif
namespace {
@@ -166,39 +170,50 @@ AutocompleteMatch& AutocompleteMatch::operator=(
}
// static
-gfx::VectorIconId AutocompleteMatch::TypeToVectorIcon(Type type) {
+const gfx::VectorIcon& AutocompleteMatch::TypeToVectorIcon(Type type) {
#if !defined(OS_ANDROID) && !defined(OS_IOS)
- static const gfx::VectorIconId kIcons[] = {
- gfx::VectorIconId::OMNIBOX_HTTP, // URL_WHAT_YOU_TYPE
- gfx::VectorIconId::OMNIBOX_HTTP, // HISTORY_URL
- gfx::VectorIconId::OMNIBOX_HTTP, // HISTORY_TITLE
- gfx::VectorIconId::OMNIBOX_HTTP, // HISTORY_BODY
- gfx::VectorIconId::OMNIBOX_HTTP, // HISTORY_KEYWORD
- gfx::VectorIconId::OMNIBOX_HTTP, // NAVSUGGEST
- gfx::VectorIconId::OMNIBOX_SEARCH, // SEARCH_WHAT_YOU_TYPED
- gfx::VectorIconId::OMNIBOX_SEARCH, // SEARCH_HISTORY
- gfx::VectorIconId::OMNIBOX_SEARCH, // SEARCH_SUGGEST
- gfx::VectorIconId::OMNIBOX_SEARCH, // SEARCH_SUGGEST_ENTITY
- gfx::VectorIconId::OMNIBOX_SEARCH, // SEARCH_SUGGEST_TAIL
- gfx::VectorIconId::OMNIBOX_SEARCH, // SEARCH_SUGGEST_PERSONALIZED
- gfx::VectorIconId::OMNIBOX_SEARCH, // SEARCH_SUGGEST_PROFILE
- gfx::VectorIconId::OMNIBOX_SEARCH, // SEARCH_OTHER_ENGINE
- gfx::VectorIconId::OMNIBOX_EXTENSION_APP, // EXTENSION_APP
- gfx::VectorIconId::OMNIBOX_SEARCH, // CONTACT_DEPRECATED
- gfx::VectorIconId::OMNIBOX_HTTP, // BOOKMARK_TITLE
- gfx::VectorIconId::OMNIBOX_HTTP, // NAVSUGGEST_PERSONALIZED
- gfx::VectorIconId::OMNIBOX_CALCULATOR, // CALCULATOR
- gfx::VectorIconId::OMNIBOX_HTTP, // CLIPBOARD
- gfx::VectorIconId::OMNIBOX_SEARCH, // VOICE_SEARCH
- gfx::VectorIconId::OMNIBOX_HTTP, // PHYSICAL_WEB
- gfx::VectorIconId::OMNIBOX_HTTP, // PHYSICAL_WEB_OVERFLOW
- };
- static_assert(arraysize(kIcons) == AutocompleteMatchType::NUM_TYPES,
- "icons array must have NUM_TYPES elements");
- return kIcons[type];
+ switch (type) {
+ case Type::URL_WHAT_YOU_TYPED:
+ case Type::HISTORY_URL:
+ case Type::HISTORY_TITLE:
+ case Type::HISTORY_BODY:
+ case Type::HISTORY_KEYWORD:
+ case Type::NAVSUGGEST:
+ case Type::BOOKMARK_TITLE:
+ case Type::NAVSUGGEST_PERSONALIZED:
+ case Type::CLIPBOARD:
+ case Type::PHYSICAL_WEB:
+ case Type::PHYSICAL_WEB_OVERFLOW:
+ return omnibox::kHttpIcon;
+
+ case Type::SEARCH_WHAT_YOU_TYPED:
+ case Type::SEARCH_HISTORY:
+ case Type::SEARCH_SUGGEST:
+ case Type::SEARCH_SUGGEST_ENTITY:
+ case Type::SEARCH_SUGGEST_TAIL:
+ case Type::SEARCH_SUGGEST_PERSONALIZED:
+ case Type::SEARCH_SUGGEST_PROFILE:
+ case Type::SEARCH_OTHER_ENGINE:
+ case Type::CONTACT_DEPRECATED:
+ case Type::VOICE_SUGGEST:
+ return omnibox::kSearchIcon;
+
+ case Type::EXTENSION_APP:
+ return omnibox::kExtensionAppIcon;
+
+ case Type::CALCULATOR:
+ return omnibox::kCalculatorIcon;
+
+ case Type::NUM_TYPES:
+ NOTREACHED();
+ break;
+ }
+ NOTREACHED();
+ return omnibox::kHttpIcon;
#else
NOTREACHED();
- return gfx::VectorIconId::VECTOR_ICON_NONE;
+ static const gfx::VectorIcon dummy = {};
+ return dummy;
#endif
}
« no previous file with comments | « components/omnibox/browser/autocomplete_match.h ('k') | components/omnibox/browser/omnibox_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698