Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Issue 2644903004: Move around more vector icons. (Closed)
Patch Set: fix comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_result_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
index a91113692703a538094cd399bf96c4a9f21c8028..7d91c966796bde09f484c897875efcecd2d4c1ee 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
@@ -26,6 +26,7 @@
#include "chrome/grit/generated_resources.h"
#include "components/grit/components_scaled_resources.h"
#include "components/omnibox/browser/omnibox_popup_model.h"
+#include "components/omnibox/browser/vector_icons.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/base/l10n/l10n_util.h"
@@ -40,7 +41,6 @@
#include "ui/gfx/range/range.h"
#include "ui/gfx/render_text.h"
#include "ui/gfx/text_utils.h"
-#include "ui/gfx/vector_icons_public.h"
#include "ui/native_theme/native_theme.h"
using ui::NativeTheme;
@@ -197,8 +197,7 @@ OmniboxResultView::OmniboxResultView(OmniboxPopupContentsView* model,
CHECK_GE(model_index, 0);
keyword_icon_->set_owned_by_client();
keyword_icon_->EnableCanvasFlippingForRTLUI(true);
- keyword_icon_->SetImage(
- GetVectorIcon(gfx::VectorIconId::OMNIBOX_KEYWORD_SEARCH));
+ keyword_icon_->SetImage(GetVectorIcon(omnibox::kKeywordSearchIcon));
keyword_icon_->SizeToPreferredSize();
}
@@ -565,19 +564,18 @@ gfx::ImageSkia OmniboxResultView::GetIcon() const {
if (!image.IsEmpty())
return image.AsImageSkia();
- return GetVectorIcon(
- model_->IsStarredMatch(match_)
- ? gfx::VectorIconId::OMNIBOX_STAR
- : AutocompleteMatch::TypeToVectorIcon(match_.type));
+ return GetVectorIcon(model_->IsStarredMatch(match_)
+ ? omnibox::kStarIcon
+ : AutocompleteMatch::TypeToVectorIcon(match_.type));
}
gfx::ImageSkia OmniboxResultView::GetVectorIcon(
- gfx::VectorIconId icon_id) const {
+ const gfx::VectorIcon& icon) const {
// For selected rows, paint the icon the same color as the text.
SkColor color = GetColor(GetState(), TEXT);
if (GetState() != SELECTED)
color = color_utils::DeriveDefaultIconColor(color);
- return gfx::CreateVectorIcon(icon_id, 16, color);
+ return gfx::CreateVectorIcon(icon, 16, color);
}
bool OmniboxResultView::ShowOnlyKeywordMatch() const {
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_result_view.h ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698