Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3494)

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Issue 2644903004: Move around more vector icons. (Closed)
Patch Set: fix comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/bubble_icon_view.cc
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
index 84b8e2346ce5262ec5a8a99418fe6de7a38779f9..081749de2f4878ac2af9b6135810faa8862f5528 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
@@ -15,12 +15,7 @@
#include "ui/views/animation/ink_drop_impl.h"
#include "ui/views/bubble/bubble_dialog_delegate.h"
-BubbleIconView::BubbleIconView(CommandUpdater* command_updater, int command_id)
- : image_(new views::ImageView()),
- command_updater_(command_updater),
- command_id_(command_id),
- active_(false),
- suppress_mouse_released_action_(false) {
+void BubbleIconView::Init() {
AddChildView(image_);
image_->set_interactive(false);
image_->EnableCanvasFlippingForRTLUI(true);
@@ -28,6 +23,13 @@ BubbleIconView::BubbleIconView(CommandUpdater* command_updater, int command_id)
SetFocusBehavior(FocusBehavior::ACCESSIBLE_ONLY);
}
+BubbleIconView::BubbleIconView(CommandUpdater* command_updater, int command_id)
+ : image_(new views::ImageView()),
+ command_updater_(command_updater),
+ command_id_(command_id),
+ active_(false),
+ suppress_mouse_released_action_(false) {}
+
BubbleIconView::~BubbleIconView() {}
bool BubbleIconView::IsBubbleShowing() const {
@@ -177,10 +179,6 @@ void BubbleIconView::ExecuteCommand(ExecuteSource source) {
command_updater_->ExecuteCommand(command_id_);
}
-gfx::VectorIconId BubbleIconView::GetVectorIcon() const {
- return gfx::VectorIconId::VECTOR_ICON_NONE;
-}
-
void BubbleIconView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
views::BubbleDialogDelegateView* bubble = GetBubble();
if (bubble)
« no previous file with comments | « chrome/browser/ui/views/location_bar/bubble_icon_view.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698