Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 2644903004: Move around more vector icons. (Closed)
Patch Set: fix comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index 01df50cd5d5298f85c692c1c1a49b3f47028cb02..a733dba9fd836a2f4150bbcbea408765b4618488 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -56,9 +56,11 @@
#include "components/bookmarks/common/bookmark_pref_names.h"
#include "components/grit/components_scaled_resources.h"
#import "components/omnibox/browser/omnibox_popup_model.h"
+#include "components/omnibox/browser/vector_icons.h"
#include "components/prefs/pref_service.h"
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_service.h"
+#include "components/toolbar/vector_icons.h"
#include "components/translate/core/browser/language_state.h"
#include "components/variations/variations_associated_data.h"
#include "components/zoom/zoom_controller.h"
@@ -76,7 +78,6 @@
#include "ui/gfx/image/image.h"
#include "ui/gfx/image/image_skia_util_mac.h"
#include "ui/gfx/paint_vector_icon.h"
-#include "ui/gfx/vector_icons_public.h"
using content::WebContents;
@@ -606,11 +607,10 @@ void LocationBarViewMac::UpdateWithoutTabRestore() {
void LocationBarViewMac::UpdateLocationIcon() {
SkColor vector_icon_color = GetLocationBarIconColor();
- gfx::VectorIconId vector_icon_id =
- ShouldShowEVBubble() ? gfx::VectorIconId::LOCATION_BAR_HTTPS_VALID
- : omnibox_view_->GetVectorIcon();
+ const gfx::VectorIcon& vector_icon_id = ShouldShowEVBubble()
+ ? toolbar::kHttpsValidIcon
+ : omnibox_view_->GetVectorIcon();
- DCHECK(vector_icon_id != gfx::VectorIconId::VECTOR_ICON_NONE);
NSImage* image = NSImageFromImageSkiaWithColorSpace(
gfx::CreateVectorIcon(vector_icon_id, kDefaultIconSize,
vector_icon_color),
@@ -714,8 +714,7 @@ NSImage* LocationBarViewMac::GetKeywordImage(const base::string16& keyword) {
SkColor icon_color =
IsLocationBarDark() ? kMaterialDarkVectorIconColor : gfx::kGoogleBlue700;
return NSImageFromImageSkiaWithColorSpace(
- gfx::CreateVectorIcon(gfx::VectorIconId::OMNIBOX_SEARCH, kDefaultIconSize,
- icon_color),
+ gfx::CreateVectorIcon(omnibox::kSearchIcon, kDefaultIconSize, icon_color),
base::mac::GetSRGBColorSpace());
}

Powered by Google App Engine
This is Rietveld 408576698