Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2644903003: Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmall… (Closed)

Created:
3 years, 11 months ago by bkonyi
Modified:
3 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmalloc. Also updated BUILD.gn files to account for include paths within the tcmalloc project. Fixed build issues from original submission. BUG= R=zra@google.com Review-Url: https://codereview.chromium.org/2623613003 . Committed: https://github.com/dart-lang/sdk/commit/5290052550f89399f7c5ad86aeab73d6693c7057

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -12 lines) Patch
M runtime/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/bin/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart.cc View 3 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/hash_map.h View 2 chunks +57 lines, -0 lines 0 comments Download
M runtime/vm/hash_map_test.cc View 2 chunks +61 lines, -0 lines 0 comments Download
M runtime/vm/malloc_hooks.h View 1 chunk +7 lines, -1 line 0 comments Download
M runtime/vm/malloc_hooks.cc View 1 chunk +251 lines, -4 lines 0 comments Download
A runtime/vm/malloc_hooks_test.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 1 chunk +26 lines, -4 lines 1 comment Download
M runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
https://codereview.chromium.org/2644903003/diff/1/runtime/vm/malloc_hooks_unsupported.cc File runtime/vm/malloc_hooks_unsupported.cc (right): https://codereview.chromium.org/2644903003/diff/1/runtime/vm/malloc_hooks_unsupported.cc#newcode13 runtime/vm/malloc_hooks_unsupported.cc:13: void MallocHooks::InitOnce() { Apparently I had forgotten to change ...
3 years, 11 months ago (2017-01-19 20:52:44 UTC) #2
zra
lgtm
3 years, 11 months ago (2017-01-19 20:56:40 UTC) #3
bkonyi
3 years, 11 months ago (2017-01-19 21:16:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5290052550f89399f7c5ad86aeab73d6693c7057 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698