Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.h

Issue 2644873002: [Sensors] Fix reading updates after page refresh (Closed)
Patch Set: Comments from haraken@. Rebased. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/SensorProxy.h
diff --git a/third_party/WebKit/Source/modules/sensor/SensorProxy.h b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
index 3787ef847c3c96b01a5a330a939d73454f1bde6f..db9977dd3c9e597bf965bfb98cafc44100ad0a75 100644
--- a/third_party/WebKit/Source/modules/sensor/SensorProxy.h
+++ b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
@@ -86,7 +86,7 @@ class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
double maximumFrequency() const { return m_maximumFrequency; }
- Document* document() const { return m_document; }
+ Document* document() const;
const WTF::Vector<double>& frequenciesUsed() const {
return m_frequenciesUsed;
}
@@ -99,7 +99,7 @@ class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
friend class SensorReadingUpdaterOnChange;
SensorProxy(device::mojom::blink::SensorType,
SensorProviderProxy*,
- Document*,
+ Page*,
std::unique_ptr<SensorReadingFactory>);
// Updates sensor reading from shared buffer.
@@ -145,7 +145,6 @@ class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
mojo::ScopedSharedBufferHandle m_sharedBufferHandle;
mojo::ScopedSharedBufferMapping m_sharedBuffer;
bool m_suspended;
- Member<Document> m_document;
Member<SensorReading> m_reading;
std::unique_ptr<SensorReadingFactory> m_readingFactory;
double m_maximumFrequency;

Powered by Google App Engine
This is Rietveld 408576698