Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: content/common/service_manager/child_connection.cc

Issue 2644843007: Always notify Mojo EDK of incomplete content child process launch (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/service_manager/child_connection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/service_manager/child_connection.cc
diff --git a/content/common/service_manager/child_connection.cc b/content/common/service_manager/child_connection.cc
index 2f73ff0452d531d655438ba9eea64dff3f5a1bca..acbb8797415713c2777f15652730f9247bd90945 100644
--- a/content/common/service_manager/child_connection.cc
+++ b/content/common/service_manager/child_connection.cc
@@ -127,14 +127,15 @@ ChildConnection::ChildConnection(
const std::string& child_token,
service_manager::Connector* connector,
scoped_refptr<base::SequencedTaskRunner> io_task_runner)
- : context_(new IOThreadContext),
+ : child_token_(child_token),
+ context_(new IOThreadContext),
child_identity_(service_name,
service_manager::mojom::kInheritUserID,
instance_id),
service_token_(mojo::edk::GenerateRandomToken()),
weak_factory_(this) {
mojo::ScopedMessagePipeHandle service_pipe =
- mojo::edk::CreateParentMessagePipe(service_token_, child_token);
+ mojo::edk::CreateParentMessagePipe(service_token_, child_token_);
context_->Initialize(child_identity_, connector, std::move(service_pipe),
io_task_runner);
@@ -146,9 +147,18 @@ ChildConnection::ChildConnection(
ChildConnection::~ChildConnection() {
context_->ShutDown();
+
+ if (process_handle_ == base::kNullProcessHandle) {
+ // The process handle was never set, so we have to assume the process was
+ // not successfully launched. Note that ChildProcessLauncher may also call
+ // call ChildProcessLaunchFailed for the same token, so this is (harmlessly)
+ // redundant in some cases.
+ mojo::edk::ChildProcessLaunchFailed(child_token_);
+ }
}
void ChildConnection::SetProcessHandle(base::ProcessHandle handle) {
+ process_handle_ = handle;
context_->SetProcessHandle(handle);
}
« no previous file with comments | « content/common/service_manager/child_connection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698