Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/chromeos/login/user_image_loader.h

Issue 264483004: UserImageLoader: Remove DCHECK requiring success of ReadFileToString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add logging as suggested by Pavel. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/user_image_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/user_image_loader.h
diff --git a/chrome/browser/chromeos/login/user_image_loader.h b/chrome/browser/chromeos/login/user_image_loader.h
index af43f5809ddfebeb1265eee2780582fec27d2912..c8ad921fc4f54cbeda81c37f672c2bb79daebcac 100644
--- a/chrome/browser/chromeos/login/user_image_loader.h
+++ b/chrome/browser/chromeos/login/user_image_loader.h
@@ -36,11 +36,12 @@ class UserImageLoader : public base::RefCountedThreadSafe<UserImageLoader>,
ImageDecoder::ImageCodec image_codec,
scoped_refptr<base::SequencedTaskRunner> background_task_runner);
- // Load an image in the background and call |loaded_cb| with the result. If
- // |size| is positive, the image is cropped to a square and shrunk so that it
- // does not exceed |size|x|size|. The first variant of this method reads the
- // image from |filepath| on disk, the second processes |data| read into memory
- // already.
+ // Load an image in the background and call |loaded_cb| with the resulting
+ // UserImage (which may be empty in case of error). If |pixels_per_side| is
+ // positive, the image is cropped to a square and shrunk so that it does not
+ // exceed |pixels_per_side|x|pixels_per_side|. The first variant of this
+ // method reads the image from |filepath| on disk, the second processes |data|
+ // read into memory already.
void Start(const std::string& filepath,
int pixels_per_side,
const LoadedCallback& loaded_cb);
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/user_image_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698